After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557182 - preview functionality
preview functionality
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on: 555740
Blocks: 557184
 
 
Reported: 2008-10-21 05:27 UTC by David Zeuthen (not reading bugmail)
Modified: 2009-01-10 03:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (50.59 KB, patch)
2008-10-21 05:28 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review
gio patch (820 bytes, patch)
2008-10-21 05:32 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review
simple test program (4.98 KB, text/plain)
2008-10-21 05:34 UTC, David Zeuthen (not reading bugmail) 		  Details

Description David Zeuthen (not reading bugmail) 2008-10-21 05:27:18 UTC 
See

 http://mail.gnome.org/archives/gvfs-list/2008-October/msg00042.html
 http://mail.gnome.org/archives/gvfs-list/2008-October/msg00055.html

Will attach the patch here since it's easier to track stuff in bugzilla.
Comment 1 David Zeuthen (not reading bugmail) 2008-10-21 05:28:08 UTC 
Created attachment 120985 [details] [review]
patch
Comment 2 David Zeuthen (not reading bugmail) 2008-10-21 05:28:53 UTC 
This depends on the GIcon serialization patch from bug 555740.
Comment 3 David Zeuthen (not reading bugmail) 2008-10-21 05:32:12 UTC 
Created attachment 120986 [details] [review]
gio patch

Also needed: Tiny patch adding G_FILE_ATTRIBUTE_PREVIEW_ICON to gio - let me know if I need to file a separate bug.
Comment 4 David Zeuthen (not reading bugmail) 2008-10-21 05:34:15 UTC 
Created attachment 120987 [details]
simple test program

Here's a test program for testing that this stuff works. Should probably be integrated into an automatic test suite.. but that seems a bit premature since one would need a specialized backend that sets preview::icon. 

For now, I'm attaching it here so it's not lost.
Comment 5 Alexander Larsson 2008-10-21 13:09:51 UTC 
I commited this with some changes. First of all I updated it to match the changes to the icon serialization APIs. 

Secondly I simplified the type handling of GVfsIcon a bit. libgvfscommon is a normal library that is always persistent (linked to directly by the daemon or made persistant by the gvfs module). Thus GvfsIcon doesn't have to be a loadable type (same as other GTypes in common/). We also don't need to call g_vfs_get_default() in the daemon to initialize it, since its a normal type and we link to the lib its in.

I can't really test this as I don't have the right hardware. Can you verify that it still works?
Comment 6 Matthias Clasen 2009-01-10 03:41:17 UTC 
I'll assume this works, David ? Please reopen if not.