After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555370 - eog should auto-refresh when file changes
eog should auto-refresh when file changes
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
2.24.x
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 503837 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-07 10:00 UTC by Sebastien Bacher
Modified: 2019-02-22 03:15 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch: autoreload unmodified images (1022 bytes, patch)
2011-09-30 18:34 UTC, Felix Riemann
accepted-commit_after_freeze Details | Review

Description Sebastien Bacher 2008-10-07 10:00:19 UTC
the bug has been described on https://bugs.launchpad.net/ubuntu/+source/eog/+bug/279471

"Binary package hint: eog

For example:

cp red.jpg image.jpg
eog image.jpg &
cp blue.jpg image.jpg

eog will keep showing the red image, even if I re-select image.jpg from the recent files list.

The use case is when I'm working on a program that outputs an image, and I keep rerunning my program on each iteration. As it is, I have to use something like kview or gwenview to avoid constantly restarting my viewer just to see the latest iteration. Even pressing alt-f,1 in eog would probably make me switch back."
Comment 1 Felix Riemann 2008-10-07 10:31:09 UTC
EOG 2.24 ships with the Reload plugin that should help here already. Once enabled it will add a tools menu to the menubar with a Reload Image command that will reload the current image. It adds an Ctrl-Shift-R shortcut as well if you prefer to use the keyboard. Unfortunately no toolbar button yet.
Comment 2 qqqqqqqqq9 2009-02-25 19:16:28 UTC
Ctrl-Shift-R is not exactly what i would call a shortcut. Since eog doesn't take text input, one could use just "r" instead, couldn't one? That would make the short a lot easier to use, especially for people who are not that agile with their fingers anymore. 

Comment 3 Felix Riemann 2009-02-28 15:03:10 UTC
(In reply to comment #2)
> Since eog doesn't
> take text input, one could use just "r" instead, couldn't one?

Thanks for that hint. Using that now, so we can use the more complicated one elsewhere. :-)


Comment 4 Felix Riemann 2009-06-11 19:44:10 UTC
*** Bug 503837 has been marked as a duplicate of this bug. ***
Comment 5 Felix Riemann 2009-06-11 19:45:54 UTC
Updating bug properties to reflect the plugin enhancement request.
Comment 6 Thomas D Ahle 2009-06-13 13:04:07 UTC
Isn't it possible for eog to use the filesystem signals to autoupdate?
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2009-07-24 19:04:35 UTC
There is bug #534348 which request reload via inotify or at least do a reload check on focus-in.

It would also rock, if the reload plugin could provide an action for the toolbar, so that one can add it there.
Comment 8 Felix Riemann 2011-09-29 14:53:57 UTC
Newer eog versions (I think >=2.32) are now asking to reload modified images (bug 534348). This is pretty much what you want, except that you need to confirm the reload. As it solves your use case and as an automatic reload is potentially "dangerous" (it could revert unsaved modifications), I'm seeing this as fixed.

This problem has been fixed in our software repository. The fix has been releases with eog-2.32. Thank you for your bug report.

P.S. Adding toolbar items by plugins is still not supported, as it would cause a race with plugin loading when starting eog (the plugin's action might not be there yet, which would drop it from the toolbar).
Comment 9 Stefan Sauer (gstreamer, gtkdoc dev) 2011-09-29 15:33:23 UTC
(In reply to comment #8)
> Newer eog versions (I think >=2.32) are now asking to reload modified images
> (bug 534348). This is pretty much what you want, except that you need to
> confirm the reload. As it solves your use case and as an automatic reload is
> potentially "dangerous" (it could revert unsaved modifications), I'm seeing
> this as fixed.

It would be lovely if you could just reload, if there are no modifications done. E.g. I am using eog as a pure viewer and don't modify images in it.
Comment 10 Felix Riemann 2011-09-30 18:20:19 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > Newer eog versions (I think >=2.32) are now asking to reload modified images
> > (bug 534348). This is pretty much what you want, except that you need to
> > confirm the reload. As it solves your use case and as an automatic reload is
> > potentially "dangerous" (it could revert unsaved modifications), I'm seeing
> > this as fixed.
> 
> It would be lovely if you could just reload, if there are no modifications
> done. E.g. I am using eog as a pure viewer and don't modify images in it.

Sounds good to me.
Comment 11 Felix Riemann 2011-09-30 18:34:19 UTC
Created attachment 197900 [details] [review]
patch: autoreload unmodified images

Dumping patch here until we branch of the stable tree from master.
Comment 12 Felix Riemann 2011-10-03 21:25:47 UTC
Checked into git master:

commit 3764db24f7d5e570b39894a05ba71a09012eea24
Author: Felix Riemann <>
Date:   Fri Sep 30 20:30:16 2011 +0200

    Auto-reload unmodified images when their file is changed
    
    It makes sense to skip the user confirmation in this case as there are
    no unsaved changed that could get lost.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=555370

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.