After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555331 - Deprecate adoption of mounts
Deprecate adoption of mounts
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 555332 555333
 
 
Reported: 2008-10-07 03:16 UTC by David Zeuthen (not reading bugmail)
Modified: 2008-10-12 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.34 KB, patch)
2008-10-07 03:55 UTC, David Zeuthen (not reading bugmail) 		none Details | Review
updated patch (3.32 KB, patch)
2008-10-07 19:09 UTC, David Zeuthen (not reading bugmail) 		accepted-commit_now Details | Review
patch that was committed (2.37 KB, patch)
2008-10-12 17:05 UTC, David Zeuthen (not reading bugmail) 		committed Details | Review

Description David Zeuthen (not reading bugmail) 2008-10-07 03:16:03 UTC 
I'm working on a "Connected Server" feature for gvfs/Nautilus. This bug is about the needed gio bits. See

 http://mail.gnome.org/archives/gvfs-list/2008-October/msg00002.html

for details.
Comment 1 David Zeuthen (not reading bugmail) 2008-10-07 03:55:46 UTC 
Created attachment 120078 [details] [review]
proposed patch
Comment 2 Matthias Clasen 2008-10-07 16:03:28 UTC 
+ * Deprecated: 2.20: Implementations of g_volume_get_mount() and
+ * g_mount_get_volumes() should instead access the union volume
+ * monitor in process and return the appropriate objects using
+ * g_volume_get_activation_root() to establish relationships.

This could do with a little code example.
Comment 3 David Zeuthen (not reading bugmail) 2008-10-07 19:08:26 UTC 
(In reply to comment #2)
> + * Deprecated: 2.20: Implementations of g_volume_get_mount() and
> + * g_mount_get_volumes() should instead access the union volume
> + * monitor in process and return the appropriate objects using
> + * g_volume_get_activation_root() to establish relationships.
> 
> This could do with a little code example.

Actually this advice is wrong now that we're using shadow mounts. Let me update the patch.
Comment 4 David Zeuthen (not reading bugmail) 2008-10-07 19:09:00 UTC 
Created attachment 120153 [details] [review]
updated patch
Comment 5 David Zeuthen (not reading bugmail) 2008-10-12 17:05:24 UTC 
Created attachment 120446 [details] [review]
patch that was committed

Committed without the connected_server identifier - I think we want to do connected servers differently (e.g. using bookmarks).

2008-10-12  David Zeuthen  <davidz@redhat.com>

        * gio.symbols:
        * gunionvolumemonitor.c:
        * gvolumemonitor.h:
        Deprecate g_volume_monitor_adopt_orphan_mount() (#555331).