After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553984 - use separator to distinguish groups instead of background color
use separator to distinguish groups instead of background color
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 441891 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-26 18:34 UTC by William Jon McCann
Modified: 2008-10-01 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.04 KB, patch)
2008-09-26 18:35 UTC, William Jon McCann 		none Details | Review
screenshot from my patch (40.43 KB, image/png)
2008-09-29 21:22 UTC, Jonathan Matthew 		  Details
screenshot with separator underneath (148.28 KB, image/png)
2008-09-30 14:50 UTC, William Jon McCann 		  Details
screenshot with more indentation (146.13 KB, image/png)
2008-09-30 15:32 UTC, William Jon McCann 		  Details

Description William Jon McCann 2008-09-26 18:34:46 UTC 
Here is a patch to use a separator to distinguish groups instead of using the background color.  We stole the background color idea from gossip.  Empathy is the new Gossip and it uses this separator technique and it looks pretty nice.
Comment 1 William Jon McCann 2008-09-26 18:35:09 UTC 
Created attachment 119441 [details] [review]
patch
Comment 2 Jonathan Matthew 2008-09-27 00:05:44 UTC 
This is pretty similar to my patch on bug 442866.  I was mostly hoping to get some feedback on how it looks, and since that hasn't happened, it's just been sitting there..

The differences appear to be that my patch puts the separator before the group name, and doesn't hide it when the group is collapsed.  Mine also cleans up empty groups correctly.

+                     "variant", is_group ? PANGO_VARIANT_SMALL_CAPS : PANGO_VARIANT_NORMAL,

Does this actually work?  It doesn't seem to do anything for me.
Comment 3 William Jon McCann 2008-09-29 14:27:38 UTC 
Right, I guess mine doesn't clean up empty groups - good point.  Can you post a screenshot of how it looks with the separator on top?

Pango doesn't implement small caps yet unfortunately.  It would be cool but we can just leave that part out for now.
Comment 4 Jonathan Matthew 2008-09-29 21:22:04 UTC 
Created attachment 119615 [details]
screenshot from my patch
Comment 5 William Jon McCann 2008-09-30 14:50:33 UTC 
Created attachment 119655 [details]
screenshot with separator underneath

For comparison
Comment 6 Bastien Nocera 2008-09-30 15:18:04 UTC 
I think we should just commit one version of the patch, and see whether people actually complain about it.
Comment 7 William Jon McCann 2008-09-30 15:32:20 UTC 
Created attachment 119659 [details]
screenshot with more indentation

Actually I don't think I like the separator approach any more.  It just adds too much visual noise.  I think using more indentation looks cleaner.

iTunes 8 uses this along with caps and a different foreground color (the foreground color actually de-emphasizes the heading).
Comment 8 William Jon McCann 2008-09-30 17:01:43 UTC 
(In reply to comment #6)
> I think we should just commit one version of the patch, and see whether people
> actually complain about it.
> 

OK, I've asked on #gnome-art and people seemed to prefer the indentation approach.  I've committed this now.

I'll consider this fixed for now.
Comment 9 William Jon McCann 2008-10-01 17:58:36 UTC 
*** Bug 441891 has been marked as a duplicate of this bug. ***