GNOME Bugzilla – Bug 553461
[publish calendar] "SSH" service type should be called "Secure FTP (SSH)"
Last modified: 2008-09-26 07:17:31 UTC
The "Publishing Location" tab in the "evolution" [*] dialog to add a calendar publishing location has a "Service type" item. One of its options is called "SSH". For the reasons mentioned in (some comments on) bug #168209 this should be: "Secure FTP (SSH)" Or one of the other suggestions of course. The important part here is that any resolution of that bug should be copied for this plugin. This is actually more of a "tracking" bug. [*] Yes, that is another bug.
Created attachment 119263 [details] [review] Rename the "SSH" option to "Secure FTP (SSH)" and update the code accordingly This patch changes the option as suggested, and also updates the enums in the code to better match the updated option. The string change from bug #553389 is also in this patch, to save having a separate one-line patch.
Just changing the glade file should be fine, instead of all the header/code. We might still use SSH internally. ANy reason, you modified the code also?
I changed the code mainly so that the enum value matched the protocol used in the URI, since all the other TYPE_* enum values match their respective protocols.
Ok :-). Commit to trunk
2008-09-26 Philip Withnall <philip@tecnocode.co.uk> ** Fix for bug #553461 and bug #553389 * publish-calendar.c (url_remove_clicked): * publish-calendar.glade: * url-editor-dialog.c (create_uri), (check_input), (publish_service_changed), (set_from_uri): * url-editor-dialog.h: Rename the "SSH" option to "Secure FTP (SSH)" and update the code accordingly. Also, change a related string to use better terminology.
We now have to check (before the next release) whether the nautilus people will also use "Secure FTP (SSH)", otherwise we end up in the situation that the dialog used by this plugin and the corresponding dialog in nautilus diverge (making the net benefit of this change rather small).