GNOME Bugzilla – Bug 553389
[publish calendar] removing of location of published calendars
Last modified: 2008-09-26 06:41:26 UTC
The Calendar Publishing plugin allows to "remove" the "Location" of a published calendar. If one does that it will popup a dialog saying: "Are you sure you want to remove this URL?" Wouldn't it be better to use "Location" instead of "URL"? (Another option would be to use (a descriptive part of) that URL.) Other information: code: /plugins/publish-calendar/publish-calendar.c/url_remove_clicked() (Not sure whether "remove" is the best choice of terminology here. But neither "delete" nor "disable" fit this action. I'll have to think about that.)
The patch attached to bug #553461 changes this.
I'd actually prefer to split the patches. Your patch would then turn into a one-liner for this bug, but that's just the way it is with single string tweaks, isn't it? You didn't add a ChaneLog entry. Not sure what the customs of this project are. Patch without ChangeLog stuff = only suggestion; patch with ChangeLog = author thinks it could be committed?
I just think a simple one-line patch which is easily integrated into another, related patch is a more efficient use of time. I thought people only had to add ChangeLog entries if they were unable to commit themselves? Changes to the ChangeLog are most likely to conflict if the patch isn't reviewed immediately.
2008-09-26 Philip Withnall <philip@tecnocode.co.uk> ** Fix for bug #553461 and bug #553389 * publish-calendar.c (url_remove_clicked): * publish-calendar.glade: * url-editor-dialog.c (create_uri), (check_input), (publish_service_changed), (set_from_uri): * url-editor-dialog.h: Rename the "SSH" option to "Secure FTP (SSH)" and update the code accordingly. Also, change a related string to use better terminology.