After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551511 - HIG problems in new xrandr display capplet
HIG problems in new xrandr display capplet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
git master
Other Linux
: Normal normal
: ---
Assigned To: Soren Sandmann Pedersen
Control-Center Maintainers
Depends on:
Blocks: randr-tracker
 
 
Reported: 2008-09-09 14:02 UTC by Christian Persch
Modified: 2009-02-26 01:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first patch (29.57 KB, patch)
2008-09-09 20:45 UTC, Christian Persch
committed Details | Review
Simple patch to reduce the margins (1019 bytes, patch)
2008-10-04 00:24 UTC, Eric Piel
committed Details | Review

Description Christian Persch 2008-09-09 14:02:37 UTC
The new xrandr display capplet has major HIG problems:
- the spacings and packings and paddings are wrong all around
- mnemonic activation on the combo boxes does not work
- wrong capitalisations in the labels (uses title cap., but should use sentense capitalisations)
- missing mnemonic on the "Mirror Scrreens" checkbox
- missing ":" on some combo boxes' labels
- the Help button does nothing
- the "Detect Displays" button is way too large

Fixing this will require a string freeze break for items 3 - 5.
Comment 1 Christian Persch 2008-09-09 20:45:29 UTC
Created attachment 118384 [details] [review]
first patch

This patch fixes the dialogue border, and reduces some of the extraneous padding inside the dialogue. (Also #if 0's some unused code so I could build without warnings.) No string changes, and the big button is still there, because I just wanted to get this out of my way before I try to find a better arrangement for it.
Comment 2 Eric Piel 2008-10-04 00:24:04 UTC
Created attachment 119896 [details] [review]
Simple patch to reduce the margins

Christian's patch is much than this one, but in case you need one small to apply to the 2.24 branch, here is a 3-lines patch that fixes the main problem: margins are far too big.
Comment 3 Jens Granseuer 2008-10-04 09:02:00 UTC
Thanks, Eric, please commit to the 2.24 branch, Christian, please commit to trunk.
Comment 4 Christian Persch 2008-10-08 21:17:25 UTC
Committed to svn trunk. Not closing the bug since items 3-5 are still outstanding; I'm going to write a patch for them later.
Comment 5 Eric Piel 2008-10-26 11:23:03 UTC
Sorry, I haven't committed my patch to the 2.24 branch because I don't have svn write access. Could someone who has write access do it for me? Thanks
(maybe I should ask for write access one day... need to find out how)
Comment 6 Jens Granseuer 2008-10-26 11:25:32 UTC
(In reply to comment #5)
> Sorry, I haven't committed my patch to the 2.24 branch because I don't have svn
> write access. Could someone who has write access do it for me?

Check patch status. Already happened a while ago. ;-)
Comment 7 Federico Mena Quintero 2009-02-26 01:32:40 UTC
I committed a beautification patch for the dialog a while ago; closing this bug :)