GNOME Bugzilla – Bug 550137
Presentation of table content in OOo Writer is largely hosed and we're double-speaking paragraphs in OOo Writer docs.
Last modified: 2009-03-10 00:05:51 UTC
In updating the regression tests for OOo Writer, I observed the following: 1. We're speaking 'unselected' for table cell content 2. We're often speaking and brailling the cell we just left before speaking and brailling the new cell. 3. When one arrows within a cell, we're not presenting the new location of the caret (or anything else for that matter). 4. We're not correctly announcing when a table has been entered (often we don't announce it, sometimes we keep announcing it over and over for the current table). 5. We're double-speaking paragraphs when navigating via Control Up and Control Down. We currently handle this via a speech.stop(). But based on comments made on the list a while back, I get the impression that we're not doing it fast enough and that a little bit gets repeated at the start. 6. We have string-specific code (looking for 'Writer' and 'Text Document'). Turns out that it's not needed. Plus it's fragile. The above are issues in OOo 2.4 as well as in OOo 3.0. In addition: 7. Sometimes we fail to say jack in tables now (OOo 3.0 dev m29 and m30). That is due to YAOOB (http://www.openoffice.org/issues/show_bug.cgi?id=93269). :-(
Created attachment 117738 [details] [review] revision 1 I'm *really* hungry and have been working on this patch a couple of days now. So I'll explain it later if need be. :-) But: 1. It pylints. 2. It seems to fix all of the issues in the opening report. (Including a work-around for the YAOOB I mentioned.) 3. It gets us down to only two Writer regression tests that fail (and one doesn't seem to be a failure as much as a change in an OOo Wizard name).
Targeting for 2.23.92 for now because things are pretty badly broken and should be fixed for 2.24. But this needs lots more testing along with a review, so I think it would be crazy to include it for 2.23.91. :-)
Created attachment 117879 [details] [review] revision 2 Will and I went over this via phone. (Thanks Will!) This patch has the changes we discussed. In addition, I took a look at Control+Up/Down in Calc. This patch has no impact. We do the expected thing when navigating amongst cells either way. When inside of (i.e. editing) a cell with multiple lines/paragraphs, we could be doing a better job in our presentation; however what we're doing now and what we're doing with this patch are the same. :-) Rule #1 is do no harm, right? ;-) I re-ran the oowriter tests for good measure as well. Also pylinted. Mike please test: * In general in Writer and Calc, ideally both 2.4 and 3.0 dev. 'Tis a big patch. :-) * In tables (moving amongst cells and within cells however the spirit moves you to move) * Navigating by paragraph Note that a recent YAOOB seems to nuke caret-moved events for newly opened documents so if you're in 3.0 dev and we're silent: 1. Try Up/Right/Left and then retest. That's their bug, not ours. 2. See if you can reproduce the problem *starting with opening the document* without the patch. Thanks much!!
This is much much better. I still have some more testing to do with different documents but this is a huge improvement.
Created attachment 118046 [details] example of the above problem
OK bugzilla is cool and didn't save my comments so here goes the comments for the above patch again. This file shows the only two problems I'm having with the patch for this bug. 1. When you down arrow from line to line notice that you hear the word "link" several times at the end of the line. 2. Notice that when you down arrow from cell to cell you first hearr the whole cell and when you down arrow again you hear the first line a second time. The first down arrow is a bit confusing as it is unclear where the cursor actuallly is. Over-all this patch is much much better.
First issue is confirmed. And it exists without the patch. You just need to remove your paragraph with the links from the table (because the table issues prevent you from getting the correct info presented). But I'll see if I can include a fix for that issue as part of this bug. Stay tuned. As for issue 2, I need to look closer. But my goal right now is to deal with issue 1. <smile>
For issue 1 I opened bug 551159. I see issue 2 and think I know the fix. But it's getting hard to keep track of patches across multiple bugs which must all be combined in order to address a given issue. Therefore, given that this patch makes things much, much better, I went ahead and checked it in. The issue 1 patch is being regression tested now. If that pans out, I'll then test my fix for issue 2. With any luck, it'll all be good within a couple of hours. <smile>
Created attachment 118188 [details] [review] deal with Mike's issue #2(repeating of paragraph with down arrow) Mike, I checked in the link-related patch as well as the work done up to now for this bug. Please pull the latest trunk and then apply this patch to it. I couldn't reproduce the repeating exactly as you described, but I found a case where I could and this patch fixed it. This is pylinted and regression tested and pretty harmless as far as I can tell. :-) In testing your sample I noticed that even with my patch for links we were not speaking the link for the entire cell (we do speak them as you arrow by line within a cell now). Turns out it's more of an Orca-wide issue (see bug 551172).
This patch seems to now address all the problems noted in this bug. Thanks much Joanie
Woo hoo!!! Thanks Mike. Patch committed. Closing as FIXED.