After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551172 - getDisplayedText() should adjustForRepeats and possibly also adjustForLinks
getDisplayedText() should adjustForRepeats and possibly also adjustForLinks
Status: RESOLVED WONTFIX
Product: orca
Classification: Applications
Component: speech
2.23.x
Other All
: Normal normal
: 2.28.0
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-06 23:39 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-05-08 15:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24



Description Joanmarie Diggs (IRC: joanie) 2008-09-06 23:39:03 UTC
Steps to reproduce:

1. Create a new folder in nautilus named "##########".

2. See what Orca says when you arrow to it.

3. See what Orca says when you do a basic whereAmI on it.

4. With it selected, see what Orca says when you read the status bar.

5. Press Return to open it and read the title of the frame/window

6. Navigate to it's toggle button (where you can go back and also choose other folders you've recently been in)

You get the idea. :-)

I initially came across this issue working on 550137 (OOo Writer table issues). When table cells in Writer documents get focus, we don't speak the links as links as part of presenting the cell content. That's because the soffice speechgenerator defaults to the default speechgenerator which ultimately calls getDisplayedText() which does various and sundry things other than adjustForLinks. A bit more looking and testing revealed it doesn't adjustForRepeats either.

I initially thought about just dealing with this in the soffice script, but curiosity got the best of me. :-) Seems like an Orca-wide issue which should be dealt with Orca-wide -- somehow. Doing it in getDisplayedText() seemed like it would be easy enough.

Thoughts?
Comment 1 Willie Walker 2008-09-08 13:00:38 UTC
(In reply to comment #0)
> speechgenerator defaults to the default speechgenerator which ultimately calls
> getDisplayedText() which does various and sundry things other than
> adjustForLinks. A bit more looking and testing revealed it doesn't
> adjustForRepeats either.

getDisplayedText is supposed to return a string that can be used for braille and speech, so I'm not sure it should be doing things like adjustForRepeats.  Instead, I wonder if adjustForRepeats probably should be pushed down into the speech module and if we should try to do something similar (if possible, though it would mean passing more knowledge about the objects around) for adjustForLinks.
Comment 2 Willie Walker 2009-05-01 14:47:52 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > speechgenerator defaults to the default speechgenerator which ultimately calls
> > getDisplayedText() which does various and sundry things other than
> > adjustForLinks. A bit more looking and testing revealed it doesn't
> > adjustForRepeats either.
> 
> getDisplayedText is supposed to return a string that can be used for braille
> and speech, so I'm not sure it should be doing things like adjustForRepeats. 
> Instead, I wonder if adjustForRepeats probably should be pushed down into the
> speech module and if we should try to do something similar (if possible, though
> it would mean passing more knowledge about the objects around) for
> adjustForLinks.

See also bug #412656, where there is discussion about pushing the adjustForRepeats down to speech.py.
Comment 3 Willie Walker 2009-05-08 15:40:31 UTC
Other bugs (bug #570658 and bug #412656) will be addressing this.