GNOME Bugzilla – Bug 548707
"New Account" title and "I already have an account" checkbox are contradictory
Last modified: 2009-06-11 11:13:16 UTC
Empathy 2.23.6, Ubuntu Intrepid Ibex alpha 3 In the Accounts window, the initial "New Account" interface ends with an "I already have an account I want to use" checkbox. This is likely contradictory: if I already have an account, it might be years old, and therefore not a New Account. One way of fixing this would be changing "New Account" to "Add Account". This would also be more obviously related to the "Add" button that revealed the interface in the first place.
I agree that the title should be "Add Account" and the checkbox should be a radio button with better label to explain both cases: 1) reusing an existing account 2) subscribe a new account. The Add button could also get "..." in the end because more input it asked.
For the ellipsis see bug #548704
Created attachment 136276 [details] [review] fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/jabber-widget-548707 src/empathy-accounts-dialog.c | 20 ++++++++++++-------- src/empathy-accounts-dialog.ui | 40 ++++++++++++++++++++++++++++++++-------- 2 files changed, 44 insertions(+), 16 deletions(-)
It looks ok; but I noticed 2.27.x got Create/Cancel buttons inverted in that page (not by this patch, but this could well be fixed at the same time).
Created attachment 136327 [details] [review] done src/empathy-accounts-dialog.c | 20 +++++++---- src/empathy-accounts-dialog.ui | 70 +++++++++++++++++++++++++++------------- 2 files changed, 59 insertions(+), 31 deletions(-)
Perfect.
Merged to master. Thanks for the review. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.