After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548707 - "New Account" title and "I already have an account" checkbox are contradictory
"New Account" title and "I already have an account" checkbox are contradictory
Product: empathy
Classification: Core
Component: Accounts
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
Depends on:
Reported: 2008-08-20 17:41 UTC by Matthew Paul Thomas (mpt)
Modified: 2009-06-11 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

fixed in;a=shortlog;h=refs/heads/jabber-widget-548707 (6.42 KB, patch)
2009-06-10 15:14 UTC, Guillaume Desmottes
none Details | Review
done (9.24 KB, patch)
2009-06-11 10:21 UTC, Guillaume Desmottes
committed Details | Review

Description Matthew Paul Thomas (mpt) 2008-08-20 17:41:32 UTC
Empathy 2.23.6, Ubuntu Intrepid Ibex alpha 3

In the Accounts window, the initial "New Account" interface ends with an "I already have an account I want to use" checkbox.

This is likely contradictory: if I already have an account, it might be years old, and therefore not a New Account.

One way of fixing this would be changing "New Account" to "Add Account". This would also be more obviously related to the "Add" button that revealed the interface in the first place.
Comment 1 Xavier Claessens 2008-08-20 18:12:02 UTC
I agree that the title should be "Add Account" and the checkbox should be a radio button with better label to explain both cases: 1) reusing an existing account 2) subscribe a new account.

The Add button could also get "..." in the end because more input it asked.
Comment 2 Xavier Claessens 2008-08-20 18:14:42 UTC
For the ellipsis see bug #548704
Comment 3 Guillaume Desmottes 2009-06-10 15:14:22 UTC
Created attachment 136276 [details] [review]
fixed in;a=shortlog;h=refs/heads/jabber-widget-548707

 src/empathy-accounts-dialog.c  |   20 ++++++++++++--------
 src/empathy-accounts-dialog.ui |   40 ++++++++++++++++++++++++++++++++--------
 2 files changed, 44 insertions(+), 16 deletions(-)
Comment 4 Frederic Peters 2009-06-10 15:42:05 UTC
It looks ok; but I noticed 2.27.x got Create/Cancel buttons inverted in that page (not by this patch, but this could well be fixed at the same time).
Comment 5 Guillaume Desmottes 2009-06-11 10:21:52 UTC
Created attachment 136327 [details] [review]

 src/empathy-accounts-dialog.c  |   20 +++++++----
 src/empathy-accounts-dialog.ui |   70 +++++++++++++++++++++++++++-------------
 2 files changed, 59 insertions(+), 31 deletions(-)
Comment 6 Frederic Peters 2009-06-11 11:04:46 UTC
Comment 7 Guillaume Desmottes 2009-06-11 11:13:16 UTC
Merged to master. Thanks for the review.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.