GNOME Bugzilla – Bug 548704
"Add" button requires further action but lacks an ellipsis
Last modified: 2009-04-21 15:45:18 UTC
Empathy 2.23.6, Ubuntu Intrepid Ibex alpha 3
In the Accounts window, someone's primary purpose in clicking the "Add" button is to set up another account. This task requires further action from the user before it is completed, so the button label should end in an ellipsis, but does not.
One way of fixing this would be to add the missing ellipsis. Another way would be to make the Add and Remove buttons icon-only.
Bug still present in current master. Adding the gnome-love keyword as it's trivial to fix.
Created attachment 126378 [details] [review]
Changed "Add" button in accounts to "Add..."
Thanks for the patch. However it removes the "+" icon from the button. Could you please fix that?
Created attachment 128819 [details] [review]
fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy.git;a=shortlog;h=refs/heads/add-button-548704
src/empathy-accounts-dialog.glade | 37 +++++++++++++++++++++++++++++++++++--
1 files changed, 35 insertions(+), 2 deletions(-)
Should be redone now we switched to GtkBuilder.
Fixed in http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/add-account-dialog
Created attachment 133047 [details] [review]
src/empathy-accounts-dialog.ui | 120 ++++++++++++++++++++++++++++++---------
1 files changed, 92 insertions(+), 28 deletions(-)
Merged to master.
Author: Guillaume Desmottes <firstname.lastname@example.org>
Date: Tue Apr 21 16:36:37 2009 +0100
Add ellipsis to the add account button. Fixes bug #548704