After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548704 - "Add" button requires further action but lacks an ellipsis
"Add" button requires further action but lacks an ellipsis
Product: empathy
Classification: Core
Component: Accounts
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
Depends on:
Reported: 2008-08-20 17:27 UTC by Matthew Paul Thomas (mpt)
Modified: 2009-04-21 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Changed "Add" button in accounts to "Add..." (1.54 KB, patch)
2009-01-13 21:44 UTC, Tim Sharitt
rejected Details | Review
fixed in;a=shortlog;h=refs/heads/add-button-548704 (2.91 KB, patch)
2009-02-16 11:01 UTC, Guillaume Desmottes
rejected Details | Review
diff (17.27 KB, patch)
2009-04-21 15:38 UTC, Guillaume Desmottes
committed Details | Review

Description Matthew Paul Thomas (mpt) 2008-08-20 17:27:59 UTC
Empathy 2.23.6, Ubuntu Intrepid Ibex alpha 3

In the Accounts window, someone's primary purpose in clicking the "Add" button is to set up another account. This task requires further action from the user before it is completed, so the button label should end in an ellipsis, but does not.

One way of fixing this would be to add the missing ellipsis. Another way would be to make the Add and Remove buttons icon-only.
Comment 1 Guillaume Desmottes 2009-01-13 00:42:31 UTC
Bug still present in current master. Adding the gnome-love keyword as it's trivial to fix.
Comment 2 Tim Sharitt 2009-01-13 21:44:11 UTC
Created attachment 126378 [details] [review]
Changed "Add" button in accounts to "Add..."
Comment 3 Xavier Claessens 2009-01-23 10:41:44 UTC
Thanks for the patch. However it removes the "+" icon from the button. Could you please fix that?
Comment 4 Guillaume Desmottes 2009-02-16 11:01:17 UTC
Created attachment 128819 [details] [review]
fixed in;a=shortlog;h=refs/heads/add-button-548704

 src/ |   37 +++++++++++++++++++++++++++++++++++--
 1 files changed, 35 insertions(+), 2 deletions(-)
Comment 5 Guillaume Desmottes 2009-04-17 09:32:15 UTC
Should be redone now we switched to GtkBuilder.
Comment 7 Guillaume Desmottes 2009-04-21 15:38:25 UTC
Created attachment 133047 [details] [review]

 src/empathy-accounts-dialog.ui |  120 ++++++++++++++++++++++++++++++---------
 1 files changed, 92 insertions(+), 28 deletions(-)
Comment 8 Guillaume Desmottes 2009-04-21 15:45:18 UTC
Merged to master.

commit 4612cc1ae9a36749e3b6f78e669343b84a77448f
Author: Guillaume Desmottes <>
Date:   Tue Apr 21 16:36:37 2009 +0100

    Add ellipsis to the add account button. Fixes bug #548704