After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543417 - [gstreamer-0.10] gst_structure_from_string.end should be nullable
[gstreamer-0.10] gst_structure_from_string.end should be nullable
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.3.x
Other All
: Normal normal
: ---
Assigned To: Jürg Billeter
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-17 11:16 UTC by Thijs Vermeir
Modified: 2008-07-17 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
make gst_structure_from_string.end nullable (590 bytes, patch)
2008-07-17 11:17 UTC, Thijs Vermeir
none Details | Review
fix other problems (3.89 KB, patch)
2008-07-17 14:55 UTC, Jared Moore
committed Details | Review

Description Thijs Vermeir 2008-07-17 11:16:59 UTC
gst_structure_from_string.end should be nullable
Comment 1 Thijs Vermeir 2008-07-17 11:17:49 UTC
Created attachment 114715 [details] [review]
make gst_structure_from_string.end nullable
Comment 2 Jared Moore 2008-07-17 14:55:30 UTC
Created attachment 114722 [details] [review]
fix other problems

There are more problems than just that. Looking at the docs, it seems like like end is an out parameter, and the return type is nullable and nonweak.

Still, this test case has gcc warnings which I'm not sure about:

using Gst;

void main() {
	string s;
	var x = Structure.from_string ("hello", out s);
}



gststructure.c: In function ‘_main’:
gststructure.c:26: warning: passing argument 2 of ‘gst_structure_from_string’ from incompatible pointer type
Comment 3 Jürg Billeter 2008-07-17 16:15:52 UTC
2008-07-17  Jürg Billeter  <j@bitron.ch>

	* vapi/packages/gstreamer-0.10/:

	Fix various binding issues, based on patches by Thijs Vermeir and
	Jared Moore, fixes bug 543348, bug 543417, and bug 543344

	* vapi/gstreamer-0.10.vapi: regenerated