GNOME Bugzilla – Bug 543344
[gstreamer-0.10] gst_registry_feature_filter binding is wrong
Last modified: 2008-07-18 09:31:06 UTC
The c declaration of this function is: GList* gst_registry_feature_filter (GstRegistry *registry, GstPluginFeatureFilter filter, gboolean first, gpointer user_data); The vala vapi is: public weak GLib.List feature_filter (Gst.PluginFeatureFilter filter, bool first); and if you use the function like this: var registry = Registry.get_default (); weak List list = registry.feature_filter (sink_caps_filter, false); The generated C code is: gst_registry_feature_filter (registry, _gst_colorspace2_sink_caps_filter_gst_plugin_feature_filter, self, FALSE); Why is 'self' inserted before the boolean and not after?
2008-07-17 Jürg Billeter <j@bitron.ch> * vapi/packages/gstreamer-0.10/: Fix various binding issues, based on patches by Thijs Vermeir and Jared Moore, fixes bug 543348, bug 543417, and bug 543344 * vapi/gstreamer-0.10.vapi: regenerated Fixed in r1711.
This commit is not fixing this, it is creating the same code.
Created attachment 114731 [details] example program Here is a small example program that demonstrates it. $ valac registry.vala --pkg gstreamer-0.10 registry.c: In function ‘_main’: registry.c:29: warning: passing argument 3 of ‘gst_registry_feature_filter’ makes integer from pointer without a cast
Created attachment 114755 [details] [review] correct patch? I think this is what the intended fix was. :)
Sure, sorry about that.
2008-07-18 Jared Moore <jaredm@svn.gnome.org> * vapi/packages/gstreamer-0.10/: Fixed gst_registry_feature_filter binding, fixes bug 543344. * vapi/gstreamer-0.10.vapi: regenerated Fixed in r1712.