After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536811 - Remove use of --resume
Remove use of --resume
Status: RESOLVED FIXED
Product: gnome-lirc-properties
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Mathias Hasselmann (IRC: tbf)
Mathias Hasselmann (IRC: tbf)
Depends on: 532606
Blocks: 530359
 
 
Reported: 2008-06-05 13:54 UTC by Bastien Nocera
Modified: 2008-09-29 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove --resume (1.68 KB, patch)
2008-06-05 13:54 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-06-05 13:54:02 UTC
As per http://sourceforge.net/tracker/index.php?func=detail&aid=1941922&group_id=5444&atid=305444 --resume shouldn't be used anymore.

As we already require 0.8.4 (for the include support), we can remove the --resume checks on irrecord.
Comment 1 Bastien Nocera 2008-06-05 13:54:32 UTC
Created attachment 112214 [details] [review]
Remove --resume
Comment 2 Bastien Nocera 2008-06-30 11:35:25 UTC
This bug requires the patch from bug 532606 to require a newer lirc though.
Comment 3 Bastien Nocera 2008-06-30 14:17:17 UTC
2008-06-30  Bastien Nocera  <hadess@hadess.net>

	* configure.ac: Remove "--resume" check
	* gnome_lirc_properties/backend.py: Remove use of the "--resume"
	flag for irrecord flags, as irrecord correctly resumes sessions
	from lirc 0.8.4 onwards (Closes: #536811)
Comment 4 Murray Cumming 2008-07-24 08:14:42 UTC
There doesn't seem to be a lirc 0.8.4 release yet, so I don't understand how we can depend on it:
http://sourceforge.net/project/showfiles.php?group_id=5444
Comment 5 Bastien Nocera 2008-07-25 07:35:07 UTC
Either ask Christof to do a new release, or ask Mario to integrate the patch in Debian/Ubuntu's lirc.

FWIW, you're also relying on 0.8.4 code for the include support, and many other things. Backing off and waiting for it to fix itself isn't the way to go.
Comment 6 Murray Cumming 2008-07-25 07:46:41 UTC
OK. I have asked on the lirc mailing list.
Comment 7 Bastien Nocera 2008-09-29 15:34:17 UTC
Is there any reasons that's still opened?
Comment 8 Murray Cumming 2008-09-29 19:29:47 UTC
There is still no lirc 0.8.4, right?
Comment 9 Bastien Nocera 2008-09-29 20:17:20 UTC
Indeed...
Comment 10 Murray Cumming 2008-09-29 21:25:07 UTC
Yeah, as you say above, we are already depending on unreleased lirc code, so let's just do that a little more. It looks like lirc won't have predictable releases any time soon so distros will continue to ship code in progress, with patches.

It seems that you already committed this patch in June anyway.