GNOME Bugzilla – Bug 532606
Include support
Last modified: 2008-06-30 14:14:58 UTC
+++ This bug was initially created as a clone of Bug #530359 +++ Small patch to make gnome-lirc-properties work with the current CVS. My guess is that you should break compatibility with older versions of lirc, otherwise you'll end having to support whether or not include support works, and which type of include it supports.
Created attachment 110715 [details] [review] glp-include-statements.patch
Thanks, and thanks for pushing this into lirc. Let's commit this with a configure check when it is available in a particular tarball version.
With an error: checking for lircd... /usr/sbin/lircd configure: WARNING: lircd >= 0.8.4 is required, you have 0.8.3pre2 checking new enough lircd daemon... configure: error: no make: *** [config.status] Error 1 Without an error: checking for lircd... /usr/sbin/lircd checking new enough lircd daemon... yes
Created attachment 110893 [details] [review] g-l-p-include-directive.patch - Checks for lircd include support (works as expected with current lircd CVS) - Remove unused LSB support - Update include syntax - Simplify code that used can_include (as we can always include now)
I don't think that I want to require include support.
I think it would be nice to keep the code simple, unless some new version of some distro is likely to use an old lirc for some reason. The old versions of distros won't take g-l-p anyway.
2008-06-30 Bastien Nocera <hadess@hadess.net> * configure.ac: Check for lirc 0.8.4 and require it * gnome_lirc_properties/backend.py: Fix include statement's syntax, it's enclosed in "<>" now * gnome_lirc_properties/lirc.py: Remove can_include check, all the lircs past 0.8.4 can support it * gnome_lirc_properties/Makefile.am: * gnome_lirc_properties/config.py.in: * gnome_lirc_properties/lsb.py: Remove use of lsb version checks, as we now require include support with a new enough lirc (Closes: #532606)