After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534814 - GIO backend does not initialize gettext properly
GIO backend does not initialize gettext properly
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: gio-file-chooser
2.22.x
Other All
: Normal normal
: future
Assigned To: Carlos Garnacho
Carlos Garnacho
Depends on:
Blocks:
 
 
Reported: 2008-05-25 20:57 UTC by Andrew Zabolotny
Modified: 2008-05-31 20:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Proposed fix (592 bytes, patch)
2008-05-25 20:59 UTC, Andrew Zabolotny
none Details | Review

Description Andrew Zabolotny 2008-05-25 20:57:44 UTC
Please describe the problem:
The GIO backend does not initialize gettext correctly during startup in gtk_file_system_gio_init(), like the gnome-VFS backend does. I don't understand exactly why, but it still gets translated text (at least the "File System" text is translated), but is returned in the wrong encoding (locale encoding rather than UTF-8). As a result, you'll get undefined chars instead of the translated "File System".


Steps to reproduce:
1. export LANG=ru_RU.KOI8-R
2. launch ufraw (the app where I have spotted this problem)


Actual results:
You'll get a number of warnings like this:

(ufraw:6149): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

and then the file selection dialog will pop up; with square marks instead of the translated "File System".


Expected results:


Does this happen every time?
yes

Other information:
I wrote a patch that fixes this bug. I'll attach it to this ticket.
Comment 1 Andrew Zabolotny 2008-05-25 20:59:16 UTC
Created attachment 111532 [details] [review]
Proposed fix

This patch does exactly the same what the VFS backend does. This fixes the bug.
Comment 2 Kjartan Maraas 2008-05-27 21:29:44 UTC
Commited to trunk. Not sure it matters for 2.22.x now since the last point release is out already.
Comment 3 Christian Persch 2008-05-31 20:02:27 UTC
libgnomeui isn't branched yet anyway, no need for a separate 2-22 commit.
And there _will_ be another release, 2.22.3.