Created attachment 111205 [details] [review]
20080520_bgo_533986_bookmark-importer: proposed rewrite to the html parser

Works perfect here, please test

Changing target, I humbly think this should go in 2.22 too, right now the feature is silently broken.
Marking so chpe (yes, you) checks it before next release :).

oops, as reinout said on IRC, I confused gnome target with target milestone.

there, fixed.

Created attachment 111253 [details] [review]
v2

Updated to cosimo's comments on IRC, uses a goto to make the regex blocks mutually exclusive for real.

I can't really comment on the regex themselves, but the code looks fine to me (maybe you can leave out the comment about why we free under the "end:" label and do not indent the code under that block, i.e. put the label on the first column and indent all the other code as usual with only one tab).

+	g_free (match_info);

Use g_match_info_free.

Let's try this on trunk first; thanks for the patch!

Committed to trunk. Leaving open until we decide if this goes to .22 too.

Forgot to mark committed (at least for trunk as i said)

Closing, we are not gonna release more .22 epiphanies it seems.

Committed to -24.