After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528288 - display warning when starting in search view&no messages displayed
display warning when starting in search view&no messages displayed
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-04-15 19:33 UTC by André Klapper
Modified: 2013-09-13 01:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed evo patch (9.43 KB, patch)
2008-04-17 14:38 UTC, Milan Crha
none Details | Review
proposed evo patch ][ (9.58 KB, patch)
2008-04-28 09:35 UTC, Milan Crha
committed Details | Review

Description André Klapper 2008-04-15 19:33:18 UTC
b.g.o gets lots of reports that people can't see their mail.
see
http://www.go-evolution.org/FAQ#I_cannot_see_some_emails.2C_but_they_must_be_there.
for possible reasons.

what i want to see:

if evolution gets **started** with a preview pane height of 0 px, reset it to a sane value. (this happens when the pane slider is at the bottom)

show a message in the message list pane *if* the message list pane is empty *because* a search view is enabled. like for the addressbook (cf. bug 228725).

if (text_inputfield != null) {
printf("No messages are displayed because you have a search view enabled to show %s", $emfb_view_items/$temp_view_items)
}
else {
printf("No messages are displayed because you have a search view enabled to show %s where %s %s", $emfb_view_items/$temp_view_items, $emfb_search_scope_items, $entered_text_value)
}

from a i18n POV the last sentence is crap, no idea yet how to do better. but you get the point.
Comment 1 Milan Crha 2008-04-17 14:38:11 UTC
Created attachment 109427 [details] [review]
proposed evo patch

for evolution;

Andre, I used different text, do you care? We can tweak it, of course, but I do not have much access for texts you requested.

I also forced a minimum size for message list and preview panel, so one will not be able to hide it (by an accident?).
Comment 2 Milan Crha 2008-04-28 09:35:34 UTC
Created attachment 110027 [details] [review]
proposed evo patch  ][

for evolution;

Fixes issue with virtual folders and no filter set, the e-sexp wasn't able to properly handle this situation, so I prechecked the value and made it happy again.
I also removed my size request set to preview and message list, it has its own size requests already set, so no need to overwrite them.
Comment 3 Srinivasa Ragavan 2008-04-30 04:07:56 UTC
Milan, looks awesome. But. Can you center the text to the message list preview ?
Comment 4 Milan Crha 2008-04-30 11:25:42 UTC
Committed to trunk. Committed revision 35459.

As discussed on IRC, I rather used the left-align, because it works a bit better than centered, furthermore with wrapping.