After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524499 - Locate pointer eats mute button
Locate pointer eats mute button
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
: 548882 570751 (view as bug list)
Depends on: 125618
Blocks:
 
 
Reported: 2008-03-26 15:53 UTC by Bastien Nocera
Modified: 2009-08-31 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsd-mouse-too-much-grab.patch (1.50 KB, patch)
2008-03-26 15:55 UTC, Bastien Nocera 		rejected Details | Review
patch (16.90 KB, patch)
2009-07-22 01:12 UTC, Matthias Clasen 		reviewed Details | Review

Description Bastien Nocera 2008-03-26 15:53:27 UTC 
using the current SVN.

1. Map volume up/volume down and mute buttons
2. Check that they work properly
3. Turn on the "locate pointer feature"
4. Press Ctrl and see that "locate pointer works"
5. Press volume up/down and see that they work properly
6. Press mute, doesn't work

Attached patch fixes it for me. the XUngrabKeyboard is definitely not needed, as there's no corresponding grab anywhere.
Comment 1 Bastien Nocera 2008-03-26 15:55:35 UTC 
Created attachment 108065 [details] [review]
gsd-mouse-too-much-grab.patch
Comment 2 Baptiste Mille-Mathias 2008-03-26 16:08:20 UTC 
I saw it eats alos row selection in rhythmbox, but not on other application (at least for now); I'll try the patch tonight
Comment 3 Bastien Nocera 2008-03-26 16:34:05 UTC 
Bleh, it's utterly broken. It's also pretty broken in the first place...
Comment 4 Bastien Nocera 2008-03-26 18:08:31 UTC 
Right, that's the good patch, but we also need to grab the pointer, and disable the keyboard grab when a mouse button is pressed at the same time as the Ctrl key is.
Comment 5 Götz Waschk 2008-08-21 17:34:30 UTC 
*** Bug 548882 has been marked as a duplicate of this bug. ***
Comment 6 Jens Granseuer 2009-02-16 09:27:02 UTC 
*** Bug 570751 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Clasen 2009-07-22 01:11:53 UTC 
The keyboard ungrab _is_ necessary to give up the keyboard grab you get when the key grab triggers.

However, just ungrabbing the keyboard there wreaks havoc with other plugins that have key grabs and expect to use the keyboard grab to get the key release events, which is what this bug is about.

I'll attach a patch that avoids the interference by moving the locate-pointer feature out to a separate process.
Comment 8 Matthias Clasen 2009-07-22 01:12:37 UTC 
Created attachment 138957 [details] [review]
patch
Comment 9 Jens Granseuer 2009-07-22 18:53:19 UTC 
Hm, I think I need a "broken indentation" stock answer...

Other than that, please commit. Thanks.
Comment 10 Matthias Clasen 2009-08-31 19:32:52 UTC 
I hope the indentation is as you want it now.