GNOME Bugzilla – Bug 524364
libglade -> gtkbuilder
Last modified: 2010-01-17 13:42:28 UTC
This is a needed migration too: http://library.gnome.org/devel/gtk/2.11/gtk-migrating-GtkBuilder.html Please leave a comment here if you plan to work on this (there has been already duplication of such migration with gio and gtkuimanager..)
Created attachment 108638 [details] [review] gstreamer-properties migration
(In reply to comment #1) > Created an attachment (id=108638) [edit] > gstreamer-properties migration > Thanks a lot, I'll review it soon!!
Looks good! Patch updated with - build dependency removed - gtk version required 2.12 - error message updated - install .ui file, and not .glade - corrected path location and test file checking We should keep glade file as long as bug 480678 is not fixed. Do you have SVN account?
bug 490678
Created attachment 108668 [details] [review] [1/1] glade->builder configure.in | 2 +- gstreamer-properties/Makefile.am | 8 +- gstreamer-properties/gstreamer-properties.c | 35 +- gstreamer-properties/gstreamer-properties.ui | 1503 ++++++++++++++++++++++++++ gstreamer-properties/pipeline-tests.c | 9 +- gstreamer-properties/pipeline-tests.h | 3 +- 6 files changed, 1531 insertions(+), 29 deletions(-)
Created attachment 109197 [details] [review] [PATCH] profiles builder configure.in | 10 +- profiles/Makefile.am | 11 +- profiles/audio-profile-choose.c | 1 - profiles/audio-profile-edit.c | 41 ++- profiles/audio-profile-private.h | 12 +- profiles/audio-profiles-edit.c | 37 +- profiles/glade/Makefile.am | 4 +- profiles/glade/gnome-media-profiles-glade.c | 27 -- profiles/gmp-util.c | 65 ++-- profiles/gmp-util.h | 9 +- profiles/gnome-audio-profile-edit.ui | 204 ++++++++++ profiles/gnome-audio-profile-new.ui | 195 ++++++++++ profiles/gnome-audio-profiles-properties.c | 8 +- profiles/gnome-audio-profiles.glade2 | 533 --------------------------- profiles/gnome-media-profiles.c | 96 +++--- profiles/gnome-media-profiles.pc.in | 2 +- 16 files changed, 540 insertions(+), 715 deletions(-)
Marc-Andre: WIlling to commit your patches now that gnome-media has branched?
It would be nice if someone else would take a look. I was planning to do it rather for next release. Although quite tempted to apply them right away.
Created attachment 137474 [details] [review] update gst-properties patch This updates the patch for gst-properties (attachment 108668 [details] [review]) to apply against the current master branch. I needed this to be able to remove the deprecated GtkOptionMenu widgets (see bug 572353). This might depend on the gtk_timeout-patch from bug 572353 comment 10 .
committed the gst-properties patch. Thanks Juan and Felix! commit 3cb78d0505273b03965cd9654a32ffad18ac6da7 Author: Juan Pizarro <jpizarrom@gmail.com> Date: Sun Jul 12 17:03:53 2009 +0300 Bug 524364 – libglade -> gtkbuilder (gst-properties) Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com> Signed-off-by: Felix Riemann <friemann@gnome.org>
Created attachment 138280 [details] [review] Bug 524364 – libglade -> gtkbuilder (profiles)
I am a bit lost with the glade update part in patch http://bugzilla.gnome.org/attachment.cgi?id=138280 Can we drop the glade catalog part?
So how can we get some progress into this? Marc-Andre, you need somebody reviewing this, right?
Review of attachment 137474 [details] [review]: You patch should also remove the glade file(s). ::: gstreamer-properties/gstreamer-properties.c @@ +40,3 @@ #include "pipeline-tests.h" +#define WID(s) gtk_builder_get_object (builder, s) This probably needs to do GTK_WIDGET () as well, otherwise we'd get warnings. ::: gstreamer-properties/pipeline-tests.c @@ +37,2 @@ #include "pipeline-tests.h" +#define WID(s) gtk_builder_get_object (builder, s) Same as above.
Review of attachment 138280 [details] [review]: I would be of the opinion that we should remove the Glade stuff for the selection widget altogether. It never had API stability promises.
(In reply to comment #14) > Review of attachment 137474 [details] [review]: > > You patch should also remove the glade file(s). > Sorry Bastien, this was committed in: commit 3cb78d0505273b03965cd9654a32ffad18ac6da7 Author: Juan Pizarro <jpizarrom@gmail.com> Date: Sun Jul 12 17:03:53 2009 +0300 Bug 524364 – libglade -> gtkbuilder (gst-properties) Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com> Signed-off-by: Felix Riemann <friemann@gnome.org> configure.ac | 2 +- gstreamer-properties/Makefile.am | 8 +- gstreamer-properties/gstreamer-properties.c | 34 +- gstreamer-properties/gstreamer-properties.glade | 1590 ----------------------- gstreamer-properties/gstreamer-properties.ui | 1503 +++++++++++++++++++++ gstreamer-properties/pipeline-tests.c | 9 +- gstreamer-properties/pipeline-tests.h | 3 +- > +#define WID(s) gtk_builder_get_object (builder, s) > > This probably needs to do GTK_WIDGET () as well, otherwise we'd get warnings. > that seems correct, but I don't see the warnings :)
(In reply to comment #15) > Review of attachment 138280 [details] [review]: > > I would be of the opinion that we should remove the Glade stuff for the > selection widget altogether. It never had API stability promises. I was afraid that sound-juicer might be using it, and that is actually the case... <widget class="Custom" id="audio_profile"> <property name="visible">True</property> <property name="can_focus">True</property> <property name="creation_function">gm_audio_profile_choose_new</property> <signal name="changed" handler="prefs_profile_changed"/> </widget>
Created attachment 151569 [details] [review] profiles: Bug 524364 - libglade -> gtkbuilder Finally remove glade from GNOME Media. I figure out that the profiles/glade directory contain a glade plugin, not for others to use in their own UI, but to be able to modify the GNOME Media UI gnome-audio-profile-edit.ui itself. This is quite important to have for now. However, A saner solution would be to fill a regular dialog, thus avoiding a custom dialog and its glade registration.
Created attachment 151570 [details] [review] profiles: Bug 524364 - libglade -> gtkbuilder Finally remove glade from GNOME Media. I figure out that the profiles/glade directory contain a glade plugin, not for others to use in their own UI, but to be able to modify the GNOME Media UI gnome-audio-profile-edit.ui itself. This is quite important to have for now. However, A saner solution would be to fill a regular dialog, thus avoiding a custom dialog and its glade registration.
yipiii!
Comment on attachment 151569 [details] [review] profiles: Bug 524364 - libglade -> gtkbuilder wrong patch
Congrats!