After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500398 - composer dropdown menu items not displayed translated
composer dropdown menu items not displayed translated
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: html-editor-control
3.17.x
Other Linux
: Normal major
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks: 236276
 
 
Reported: 2007-11-29 10:49 UTC by André Klapper
Modified: 2007-11-30 17:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (16.15 KB, image/png)
2007-11-29 10:53 UTC, André Klapper 		  Details
proposed gtkthml patch (1.65 KB, patch)
2007-11-30 16:18 UTC, Milan Crha 		committed Details | Review

Description André Klapper 2007-11-29 10:49:29 UTC 
/components/html-editor/paragraph-style.c

if you start the composer and take a look at the "normal/preformat/.../address" dropdown menu below the subject line, you will see that in german and czech, only the first and the last item get displayed translated, though the .po files of these languages are complete.
Comment 1 André Klapper 2007-11-29 10:53:23 UTC 
Created attachment 99835 [details]
screenshot
Comment 2 Milan Crha 2007-11-30 16:18:35 UTC 
Created attachment 99914 [details] [review]
proposed gtkthml patch

for gtkhtml;
Comment 3 Matthew Barnes 2007-11-30 17:06:59 UTC 
This confused me at first but I think I see the problem now.

When GNOME_GTKHTML_EDITOR_SHLIB is defined the code should be calling dgettext() instead of gettext().  The _() macro does the right thing, so Milan's patch is correct.  Nice job.
Comment 4 André Klapper 2007-11-30 17:11:01 UTC 
yeah, works fine here. wonderful, thanks, please get this in for stable and trunk (it's not a string freeze break and i also assume that no documentation is affected, so it can just go in)
Comment 5 Milan Crha 2007-11-30 17:37:11 UTC 
Committed to trunk. Committed revision 8637.
Committed to stable. Committed revision 8638.

Matt, I thought about exactly that, I just had no clue.