After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 490182 - Histogram updating
Histogram updating
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.4.x
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 496441 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-25 15:37 UTC by Andrea Olivotto
Modified: 2008-10-30 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rouch outline of the proposed fix (5.23 KB, patch)
2007-10-25 17:05 UTC, Sven Neumann
none Details | Review

Description Andrea Olivotto 2007-10-25 15:37:18 UTC
Could be enormously useful if the histogram could be updated in real time using levels and curves (and maybe other image filters), following the image preview. Better, the old histogram could be grayed in the background, the previewed black in the foreground. 
This is nearly mandatory retouching photos, especially using levels.
Many many thanks if you could make this (and sorry for my english).

Other information:
Comment 1 Sven Neumann 2007-10-25 16:30:07 UTC
Actually, I am pretty sure that it used to do that.
Comment 2 Sven Neumann 2007-10-25 16:37:10 UTC
This is most probably caused by this change:

2007-06-27  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimagemap.c (gimp_image_map_clear)
	(gimp_image_map_do): update the image, not the drawable so we
	avoid constantly invalidating the drawable preview.

	* app/tools/gimpimagemaptool.c (gimp_image_map_tool_response):
	invalidate the drawable preview here.
Comment 3 Sven Neumann 2007-10-25 16:42:52 UTC
I suggest that above change is reverted. The image-map tools should update the drawable and the histogram should be updated whenever the drawable data changes (currently it listens to invalidate-preview, which is also incorrect). In order to suppress updates of the preview, we could introduce gimp_viewable_preview_freeze() and gimp_viewable_preview_thaw().
Comment 4 Sven Neumann 2007-10-25 17:05:43 UTC
Created attachment 97863 [details] [review]
rouch outline of the proposed fix
Comment 5 Sven Neumann 2007-10-26 14:44:39 UTC
I have committed something along those lines:

2007-10-26  Sven Neumann  <sven@gimp.org>

	Reenabled update of the histogram while doing color corrections
	(bug 490182):

	* app/core/gimpviewable.[ch]: added new methods preview_freeze()
	and preview_thaw().

	* app/core/gimpimagemap.c
	(gimp_image_map_new): freeze the drawable preview.
	(gimp_image_map_dispose): thaw the  drawable preview.
	(gimp_image_map_do): update the drawable, not the image.

	* app/tools/gimpimagemaptool.c (gimp_image_map_tool_response): no
	need to invalidate the drawable preview any longer.
Comment 6 Andrea Olivotto 2007-10-29 10:34:35 UTC
Is it possible to have the old histogram grayed in the background when I'm using levels (or curves or other color modifications)?

Thanks!
Comment 7 Sven Neumann 2007-10-29 19:26:18 UTC
You have the old histogram in the Levels or Curves dialog and the updating histogram in the Histogram window. That is the behavior from 2.2 which has been restored by the bug-fix. This bug is now closed and it is futile to add further comments to it.
Comment 8 Andrea Olivotto 2007-10-31 09:56:01 UTC
I don't want to be spoiled or pressing, but retouching photo is useful to see old and current histograms superimposed, on the same window.

Sorry, maybe I'm wrong to write this comment here. Please be patient, I'm not confident with bugzilla.

Andrea
Comment 9 Sven Neumann 2007-11-13 15:57:53 UTC
*** Bug 496441 has been marked as a duplicate of this bug. ***