After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 477529 - Fullscreen poup controls is never removed
Fullscreen poup controls is never removed
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.19.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 452245 478980 497931 501099 504919 509849 524934 525638 557322 (view as bug list)
Depends on: 478371
Blocks:
 
 
Reported: 2007-09-16 16:50 UTC by Niklas Mellegård
Modified: 2008-10-21 21:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Description Niklas Mellegård 2007-09-16 16:50:11 UTC 
Please describe the problem:
Under very specific circumstances are the fullscreen controls never removed, even when leaving fullscreen mode.


Steps to reproduce:
1. Start totem, load a movie and enter fullscreen mode
2. When in fullscreen, click on the volume button so the slider is shown
3. Press the Escape button to cancel the volume slider


Actual results:
The result is that the popups don't get removed, ever. Not even leaving fullscreen mode helps


Expected results:
The same behaviour as when the volume slider is removed due to clicking the mouse button outside the slider.

Does this happen every time?
Yes

Other information:
The cause of this bug is that the volume sliders release event callback (totem_fullscreen_vol_slider_released_cb) never gets called when it's been closed with the Escape key (only when clicking ouside the volume slider), thus the totem->fs->vol_lock remains TRUE with the effect that the timer callback (totem_fullscreen_popup_hide) that should remove the popup is cancelled.
Comment 1 Bastien Nocera 2007-09-19 10:50:51 UTC 
There's a few problems with the scale button indeed. We have no ways of knowing whether it's popped up or not.
Comment 2 Bastien Nocera 2007-09-19 13:57:03 UTC 
Fixed in gnome-2-20 and trunk

2007-09-19  Bastien Nocera  <hadess@hadess.net>

        * data/fullscreen.ui:
        * src/totem-fullscreen.c: (totem_fullscreen_popup_timeout_add),
        (totem_fullscreen_is_volume_popup_visible),
        (totem_fullscreen_force_popup_hide), (totem_fullscreen_popup_hide),
        (totem_fullscreen_set_fullscreen), (totem_fullscreen_new):
        Remove the vol_lock, and check whether the popup is visible instead
        Force the volume scale to popdown when going out of fullscreen
        (Closes: #477529, #452245)
Comment 3 Bastien Nocera 2007-10-04 11:50:12 UTC 
*** Bug 452245 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2007-10-04 11:58:53 UTC 
Really fix it this time, in both gnome-2-20 and trunk. We still need the GTK+ patch for it though.

2007-10-04  Bastien Nocera  <hadess@hadess.net>

        * src/totem-fullscreen.c: (totem_fullscreen_get_volume_popup),
        (totem_fullscreen_is_volume_popup_visible),
        (totem_fullscreen_parent_window_notify): Only hide the popup if the
        volume popup isn't visible (Closes: #477529), requires GTK+ patch
        from bug #478371
        * src/totem.c: Remove unneeded functions leftover from glade use in
        the past
Comment 5 Bastien Nocera 2007-10-04 15:49:56 UTC 
*** Bug 478980 has been marked as a duplicate of this bug. ***
Comment 6 Bastien Nocera 2007-11-18 19:16:40 UTC 
*** Bug 497931 has been marked as a duplicate of this bug. ***
Comment 7 Bastien Nocera 2007-12-02 19:34:09 UTC 
*** Bug 501099 has been marked as a duplicate of this bug. ***
Comment 8 Bastien Nocera 2007-12-23 11:06:13 UTC 
*** Bug 504919 has been marked as a duplicate of this bug. ***
Comment 9 Philip Withnall 2008-03-29 14:43:11 UTC 
*** Bug 524934 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2008-04-02 10:42:28 UTC 
*** Bug 525638 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2008-04-27 00:21:58 UTC 
*** Bug 509849 has been marked as a duplicate of this bug. ***
Comment 12 Bastien Nocera 2008-10-21 21:42:36 UTC 
*** Bug 557322 has been marked as a duplicate of this bug. ***