GNOME Bugzilla – Bug 475781
Leaks around ECalComponentDateTime
Last modified: 2013-09-13 00:56:27 UTC
During my work on bug #415817 I found that there can be couple of leaks around usage of ECalComponentDateTime, so I will attach here patch for evolution and evolution-data-server, where it will free memory properly. Patch at bug #415817 covers fix in evolution-data-server/calendar/backends/file/e-cal-backend-file.c so I will skip this file here.
Created attachment 95337 [details] [review] proposed eds patch for evolution-data-server; I also changed body of e_cal_component_free_datetime, so it indicates already freed data and it can be called twice without any harm.
Created attachment 95339 [details] [review] proposed evo patch for evolution;
Chen, seems like a candidate for 2.21.4
chen 2.21.5?
Would be nice to get this in soon.
On EDS side, Free end date and due date (e-cal-backend-groupwise-utils.c) inside the if block for consistency. The patches looks good to commit.
Created attachment 103723 [details] [review] Fixes a huge leak. Just found it with the help of traces from dave while testing print.
Created attachment 103724 [details] [review] Leak fix in evolution while printing month view.
for parts on 2007-09-11: eds part (slightly modified) committed to trunk. Committed revision 8423. evo part committed to trunk. Committed revision 34895.
The first patch looks fine, just add same call e_cal_component_free_datetime (&instance_recur_id.datetime); just before the "continue;" statement above the place you added these two, to have it 100% correct. (also add Changelog entry as in the next patch) :) The evo patch is just great :)
Patch in e-d-s committed to SVN trunk as r8433 (http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=8433) Patch in evolution committed to SVN trunk as r34908 (http://svn.gnome.org/viewvc/evolution?view=revision&revision=34908)