After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 471701 - gdict has an unlocalized license text.
gdict has an unlocalized license text.
Status: RESOLVED DUPLICATE of bug 336225
Product: gnome-utils
Classification: Deprecated
Component: gdict
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-30 05:12 UTC by Takao Fujiwara
Modified: 2008-03-21 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for gnome-dictionary/src/gdict-about.c (2.32 KB, patch)
2007-08-30 05:13 UTC, Takao Fujiwara
none Details | Review

Description Takao Fujiwara 2007-08-30 05:12:44 UTC
gdict has an unlocalized license text due to no gettext. I think it's better
 to have the localized text since other modules have done.

To reproduce:
1. Invoke gdict.
2. Choose [Help] -> [About] and launch the about dialog.
3. Click [License] button and launch [License] dialog.

Then the license text is not localized.
I'm attaching the patch.
Comment 1 Takao Fujiwara 2007-08-30 05:13:42 UTC
Created attachment 94592 [details] [review]
Patch for gnome-dictionary/src/gdict-about.c

Attached the patch.

Could you review it?
Comment 2 Emmanuele Bassi (:ebassi) 2007-09-04 14:28:23 UTC
this should be solved at gtk+ level - and there is a bug opened already (see bug 336225). also, licenses are not usually binding when translated, so I don't know whether this should be done or not.

marking as duplicate of bug 336225 in the hope that this is solved at the right level of the stack.

*** This bug has been marked as a duplicate of 336225 ***
Comment 3 Takao Fujiwara 2008-03-21 11:30:33 UTC
The duplicating bug is dispatched. 
Is it possible to have the fix in gdict side?
Comment 4 Emmanuele Bassi (:ebassi) 2008-03-21 11:40:17 UTC
(In reply to comment #3)

> Is it possible to have the fix in gdict side?

I really don't see the point; the proper fix is to resolve bug 336225. also, comment 37 on that bug (correctly) states that:

  Translations (of FSF licenses, at least) are always unofficial

in any case, if we start translating every single license for every single application we'll get an explosion of size in the .mo files, which will impact on startup time.
Comment 5 Takao Fujiwara 2008-03-21 12:15:22 UTC
The main problem is that gdict only does not provide the translations in GNOME so the problem visibility is high.
If you compare other applications and consider the option again, it would be great.

Comment 37 is right. Community translations always have the risk of translation qualities. Sun also has the different translations with legal reviews if we start the license translations.

This bug introduce unlocalized text in gdict as other application fixes this issue.
I agree it's better to fix bug 336225 but how about having the local fix until bug 336225 is fixed?

I don't think this fix causes an explosion of size in the .mo files because the word counts are really small. I'm also working the l10n pakcaging and translations and I completely understand the way.