After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 454071 - Epiphany crashes while updating adblock rules
Epiphany crashes while updating adblock rules
Status: RESOLVED DUPLICATE of bug 452119
Product: epiphany-extensions
Classification: Deprecated
Component: adblock
2.19.x
Other All
: Normal critical
: ---
Assigned To: epiphany-extensions-maint
epiphany-extensions-maint
Depends on:
Blocks:
 
 
Reported: 2007-07-05 20:10 UTC by Michael Kuhn
Modified: 2007-07-06 01:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Check for errors (767 bytes, patch)
2007-07-05 20:11 UTC, Michael Kuhn 		none Details | Review

Description Michael Kuhn 2007-07-05 20:10:29 UTC 
Steps to reproduce:
1. Open adblock editor UI
2. Switch to tab 'Filterset.G'
3. Click the update button

Stack trace:

+ Trace 145973

  • #0 adblock_pattern_get_filtersetg_patterns
    at adblock-pattern.c line 190
  • #1 adblock_ui_load_cb
    at adblock-ui.c line 329
  • #2 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #3 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #4 ??
    from /usr/lib/libgobject-2.0.so.0
  • #5 ??
  • #6 ?? 

Other information:
Epiphany crashes, because the adblock plugin doesn't do sufficient error checking: if the patterns file can't be downloaded, adblock_pattern_rewrite_patterns() gets called with contents = NULL and later crashes, because NULL is dereferenced (line = *t++).

I'm attaching a patch that should fix this.
Comment 1 Michael Kuhn 2007-07-05 20:11:10 UTC 
Created attachment 91271 [details] [review]
Check for errors
Comment 2 Paul Cutler 2007-07-06 01:09:54 UTC 
Bug is a duplicate of 452119Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 452119 ***