Bug 452119 – crash in Epiphany Web Browser: Trying to update the Fil...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 452119 - crash in Epiphany Web Browser: Trying to update the Fil...


Summary:	crash in Epiphany Web Browser: Trying to update the Fil...


Status:	RESOLVED FIXED

Product:	epiphany-extensions
Classification:	Deprecated
Component:	adblock
Version:	2.18.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	gnome-2-20
Assigned To:	epiphany-extensions-maint
QA Contact:	epiphany-extensions-maint

URL:
Whiteboard:	This bug is on the auto-stacktrace-re...

Duplicates:	451943 452765 452926 453194 454071 454416 456943 457355 457872 459968 460145 460576 461361 464614 465837 467444 467802 468073 468585 468730 469002 469211 469441 470904 471474 472707 473551 478281 479001 479002 487091 488034 491827 500637 (view as bug list)
Depends on:
Blocks:

Reported:	2007-06-29 02:16 UTC by Mark Rosenstand
Modified:	2007-11-30 23:54 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
Added support for new filterset.g update process. (1.68 KB, patch) 2007-07-03 13:43 UTC, Jean-François Rameau	accepted-commit_now	Details \| Review

Description Mark Rosenstand 2007-06-29 02:16:01 UTC

Version: 2.18.2

What were you doing when the application crashed?
Trying to update the Filterset.G rules using "Adblock editor"


Distribution: Fedora release 7 (Moonshine)
Gnome Release: 2.18.2 2007-05-28 (Red Hat, Inc)
BugBuddy Version: 2.18.0

System: Linux 2.6.21-1.3228.fc7 #1 SMP Tue Jun 12 15:37:31 EDT 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 10300000
Selinux: No
Accessibility: Disabled
GTK+ Theme: Clearlooks
Icon Theme: Echo

Memory status: size: 130134016 vsize: 130134016 resident: 54067200 share: 37720064 rss: 54067200 rss_rlim: 4294967295
CPU usage: start_time: 1183083250 rtime: 157 utime: 146 stime: 11 cutime:0 cstime: 1 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/epiphany'

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1208658208 (LWP 13264)]
[New Thread -1257915504 (LWP 13278)]
[New Thread -1219150960 (LWP 13277)]
[New Thread -1208661104 (LWP 13276)]
0x00f8d402 in __kernel_vsyscall ()

+ Trace 144506

Thread 1 (Thread -1208658208 (LWP 13264))

#0 __kernel_vsyscall
#1 waitpid
from /lib/libpthread.so.0
#2 ??
from /usr/lib/libgnomeui-2.so.0
#3 nsProfileLock::FatalSignalHandler
at nsProfileLock.cpp line 210
#4 <signal handler called>
#5 adblock_pattern_get_filtersetg_patterns
at adblock-pattern.c line 190
#6 adblock_ui_load_cb
at adblock-ui.c line 329
#7 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#8 IA__g_closure_invoke
at gclosure.c line 490
#9 signal_emit_unlocked_R
at gsignal.c line 2440
#10 IA__g_signal_emit_valist
at gsignal.c line 2199
#11 IA__g_signal_emit
at gsignal.c line 2243
#12 IA__gtk_button_clicked
at gtkbutton.c line 889
#13 gtk_real_button_released
at gtkbutton.c line 1484
#14 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#15 g_type_class_meta_marshal
at gclosure.c line 567
#16 IA__g_closure_invoke
at gclosure.c line 490
#17 signal_emit_unlocked_R
at gsignal.c line 2370
#18 IA__g_signal_emit_valist
at gsignal.c line 2199
#19 IA__g_signal_emit
at gsignal.c line 2243
#20 IA__gtk_button_released
at gtkbutton.c line 881
#21 gtk_button_button_release
at gtkbutton.c line 1377
#22 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 84
#23 g_type_class_meta_marshal
at gclosure.c line 567
#24 IA__g_closure_invoke
at gclosure.c line 490
#25 signal_emit_unlocked_R
at gsignal.c line 2478
#26 IA__g_signal_emit_valist
at gsignal.c line 2209
#27 IA__g_signal_emit
at gsignal.c line 2243
#28 gtk_widget_event_internal
at gtkwidget.c line 3915
#29 IA__gtk_propagate_event
at gtkmain.c line 2341
#30 IA__gtk_main_do_event
at gtkmain.c line 1575
#31 gdk_event_dispatch
at gdkevents-x11.c line 2318
#32 IA__g_main_context_dispatch
at gmain.c line 2045
#33 g_main_context_iterate
at gmain.c line 2677
#34 IA__g_main_loop_run
at gmain.c line 2881
#35 IA__gtk_main
at gtkmain.c line 1154
#36 main
at ephy-main.c line 709
#0 __kernel_vsyscall



----------- .xsession-errors (105508 sec old) ---------------------
                LIMIT 1'
Executing reader on sql 'INSERT INTO Tracks (TrackID, Uri, MimeType, Artist, Performer, AlbumTitle, ASIN, Label, Title, Genre, Year, DateAddedStamp, TrackNumber, TrackCount, Duration, Rating, NumberOf
Executing reader on sql '
                    SELECT TrackID
                    FROM Tracks
                    WHERE Uri = :uri
                    LIMIT 1'
Executing reader on sql '
                SELECT * 
                FROM Tracks
                WHERE Uri = :uri
                    OR TrackID = :uri
                LIMIT 1'
Executing reader on sql 'INSERT INTO Tracks (TrackID, Uri, MimeType, Artist, Performer, AlbumTitle, ASIN, Label, Title, Genre, Year, DateAddedStamp, TrackNumber, TrackCount, Duration, Rating, NumberOf
...Too much output, ignoring rest...
--------------------------------------------------

Comment 1 Christian Persch 2007-06-29 09:48:44 UTC

I see the problem:

        t = lines = g_strsplit (contents, "\n", 0);

        while (TRUE)
        {
190                line = *t++;

t can be NULL since g_strsplit can return NULL; so this is a null-deref. Easy fix.

Comment 2 Christian Persch 2007-07-02 11:03:00 UTC

*** Bug 452926 has been marked as a duplicate of this bug. ***

Comment 3 Christian Persch 2007-07-02 11:03:13 UTC

*** Bug 451943 has been marked as a duplicate of this bug. ***

Comment 4 Christian Persch 2007-07-02 11:17:31 UTC

*** Bug 452765 has been marked as a duplicate of this bug. ***

Comment 5 Christian Persch 2007-07-02 19:13:05 UTC

*** Bug 453194 has been marked as a duplicate of this bug. ***

Comment 6 Jean-François Rameau 2007-07-03 13:43:06 UTC

Created attachment 91104 [details] [review]
Added support for new filterset.g update process.

filterset.g now has static file pointing to last update (latest.txt).
Added some checks to avoid crashes.

Comment 7 Christian Persch 2007-07-03 15:04:11 UTC

Thanks!

Comment 8 Paul Cutler 2007-07-06 01:09:54 UTC

*** Bug 454071 has been marked as a duplicate of this bug. ***

Comment 9 palfrey 2007-07-07 21:24:36 UTC

*** Bug 454416 has been marked as a duplicate of this bug. ***

Comment 10 Jean-François Rameau 2007-07-08 09:34:49 UTC

Commit done both on gnome-2.18 branch and trunk.

Comment 11 Pedro Villavicencio 2007-07-14 22:36:52 UTC

*** Bug 456943 has been marked as a duplicate of this bug. ***

Comment 12 Reinout van Schouwen 2007-07-19 14:20:41 UTC

*** Bug 457872 has been marked as a duplicate of this bug. ***

Comment 13 Reinout van Schouwen 2007-07-19 14:48:00 UTC

*** Bug 457355 has been marked as a duplicate of this bug. ***

Comment 14 Reinout van Schouwen 2007-07-24 20:26:37 UTC

*** Bug 459968 has been marked as a duplicate of this bug. ***

Comment 15 Reinout van Schouwen 2007-07-25 09:09:37 UTC

*** Bug 460145 has been marked as a duplicate of this bug. ***

Comment 16 Reinout van Schouwen 2007-07-26 13:58:48 UTC

*** Bug 460576 has been marked as a duplicate of this bug. ***

Comment 17 Reinout van Schouwen 2007-07-29 11:49:45 UTC

*** Bug 461361 has been marked as a duplicate of this bug. ***

Comment 18 Reinout van Schouwen 2007-08-09 11:43:41 UTC

*** Bug 464614 has been marked as a duplicate of this bug. ***

Comment 19 Reinout van Schouwen 2007-08-12 10:14:55 UTC

*** Bug 465837 has been marked as a duplicate of this bug. ***

Comment 20 Reinout van Schouwen 2007-08-16 21:37:19 UTC

*** Bug 467444 has been marked as a duplicate of this bug. ***

Comment 21 Reinout van Schouwen 2007-08-17 23:09:40 UTC

*** Bug 467802 has been marked as a duplicate of this bug. ***

Comment 22 Reinout van Schouwen 2007-08-19 23:46:53 UTC

*** Bug 468073 has been marked as a duplicate of this bug. ***

Comment 23 Reinout van Schouwen 2007-08-20 22:48:05 UTC

*** Bug 468585 has been marked as a duplicate of this bug. ***

Comment 24 Reinout van Schouwen 2007-08-21 08:46:25 UTC

*** Bug 468730 has been marked as a duplicate of this bug. ***

Comment 25 Reinout van Schouwen 2007-08-21 22:14:25 UTC

*** Bug 469002 has been marked as a duplicate of this bug. ***

Comment 26 Reinout van Schouwen 2007-08-22 12:02:30 UTC

*** Bug 469211 has been marked as a duplicate of this bug. ***

Comment 27 Reinout van Schouwen 2007-08-23 00:31:11 UTC

*** Bug 469441 has been marked as a duplicate of this bug. ***

Comment 28 Reinout van Schouwen 2007-08-28 00:31:35 UTC

*** Bug 470904 has been marked as a duplicate of this bug. ***

Comment 29 Reinout van Schouwen 2007-08-30 00:00:41 UTC

*** Bug 471474 has been marked as a duplicate of this bug. ***

Comment 30 Reinout van Schouwen 2007-09-02 20:03:15 UTC

*** Bug 472707 has been marked as a duplicate of this bug. ***

Comment 31 Reinout van Schouwen 2007-09-04 12:57:00 UTC

*** Bug 473551 has been marked as a duplicate of this bug. ***

Comment 32 Reinout van Schouwen 2007-09-19 07:59:28 UTC

*** Bug 478281 has been marked as a duplicate of this bug. ***

Comment 33 Reinout van Schouwen 2007-09-21 15:44:58 UTC

*** Bug 479002 has been marked as a duplicate of this bug. ***

Comment 34 Reinout van Schouwen 2007-09-21 15:45:57 UTC

*** Bug 479001 has been marked as a duplicate of this bug. ***

Comment 35 Reinout van Schouwen 2007-10-16 09:52:11 UTC

*** Bug 487091 has been marked as a duplicate of this bug. ***

Comment 36 Reinout van Schouwen 2007-10-18 21:13:44 UTC

*** Bug 488034 has been marked as a duplicate of this bug. ***

Comment 37 Reinout van Schouwen 2007-10-31 22:53:03 UTC

*** Bug 491827 has been marked as a duplicate of this bug. ***

Comment 38 Reinout van Schouwen 2007-11-30 23:54:37 UTC

*** Bug 500637 has been marked as a duplicate of this bug. ***