GNOME Bugzilla – Bug 452047
Invite user to add metadata to MusicBrainz when not present
Last modified: 2014-03-24 16:38:49 UTC
From Ross' blog[1] -- When Musicbrainz can't find the track listing for a CD, it automatically queries FreeDB and will attempt to return something from the garbled nonsense that FreeDB generally contains. The user cannot tell the difference, unless they notice that the track listings are badly formatted, the album artist is incorrect, or the encoding is wrong. The user will not notice any trivial issues, fix any obvious problems and then rip the CD, or just give up now if the encoding is wrong. This is bad. What should happen is that Sound Juicer should subtly point out to the user if the data is proxied from FreeDB, so that they can import it into MusicBrainz where more data can be added and verified. What I'd like to see is a little pane appear if a CD is from FreeDB (SJ knows this already) with a link to the relevant import URL, so the user can quickly import it once for the benefit of everyone else who rips the album in the future. -- [1] - http://www.burtonini.com/blog/computers/sound-juicer/sj-love-2007-06-20-14-30
Created attachment 90836 [details] [review] sj-message-area.patch This is a fist attempt to make a patch adding a MessageArea (used also by gedit and other applications) to invite the user to add metadata to MusicBrainz. * The patch is huge but .glade file should be not much more than reindentation. * sj-message-area.[hc] are taken from gedit project (thanks :) * I have added a metadata_source to struct _TrackDetails so we can do specific things when metadata are retrieved from CD TEXT, like using a default URL for submitting metadata (MusicBrainz homepage?). This "feature" is not implemented at the moment. * The patch is not yet finished, I have to and handle "Submit Album" button. * there is a redrawing bug. Paolo Borelli remembers something similar experieced by someone else, but he isn't aware of a solution/workaround. See next attachment for a screenshot.
Created attachment 90837 [details] sj-message-area-corrupted.png
Adding Paolo to CC list :)
Hey! I would love for this to be implemented, as per my comment, which I'll partially reproduce here: I have encountered problems with my SJ rips on two CD's (fairly obscure), and found that they were solved by submitting the disc TOC. After rescanning the CD, it worked just fine. This popup thing will be really helpful, so I know when to submit TOC's. I would also suggest having a button in the popup for submitting TOC, as well as submitting the album. If a missing TOC is the problem, submitting the album would be bad...I'm not entirely sure how that'd even work out. I don't know if there's an easy way to submit a album title along with the TOC that goes when you click "Submit Tracks" (a quick glance didn't see anything), but if so, it'd be good to submit the album title from FreeDB if adding the TOC. Also, I'm not just posting a wishlist - I have never coded GTK+, but I'd love to get started if help is needed here. I don't know how (or if) one would distinguish between missing TOC and missing Album - I don't know enough about how MusicBrainz or Sound Juicer to know if that's a) possible or b) easy.
How is this patch going, and how can I help? I would really like this feature :)
Joel, at the moment the patch is a bit stalled due to the redraw bug.
*** Bug 498472 has been marked as a duplicate of this bug. ***
Committed to svn. We'll work on the redraw bug!
maybe I am on crack (I have not followed the bug closely), but I think that if you upgrade to the latest copy of gedit-message-area (which should require no changes to the calling code) the redrawing bug may be fixed already. btw, I really think that renaming the widget and changing indentation is a vary bad idea and will make your life harder in the future...
Paolo, I resynced with gedit svn trunk today to see what happened, and now whilst I don't get any redraw bugs I don't get it painted in the tooltip colour, but the normal window background colour. :( And yes, I'm going to replace sj-message-area with a pristine gedit source file.
*** Bug 335943 has been marked as a duplicate of this bug. ***
Ross, with which theme do you get the wrong background? We changed it to use the style of the new gtk tooltips instead of the old tooltips widget because themes started to specify that one and omit the older one...
Darkilouche and Human.
in gedit it works for me with Human (on gutsy)
Ross, svn trunk works well here too, tested with several themes :) Paolo, sorry for having renamed the widget and changed indentation, it was done to follow sj coding style, but indeed not a very good idea.
This bug solution is incomplete since there is no way to get rid of this nag screen. There are people which definitly do not want to contribute to MusicBrainz since this service doesn't allow annonymous usage. This renders the service non-free.
As I've said before you press the Close button. If you want to hide the cluebar permamently then I suggest you comment out line 571 of sj-main.c (gtk_widget_show(message_area)) or use something like Grip or Goobox.