After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442398 - Option to reorder and hide calendar groups
Option to reorder and hide calendar groups
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
3.4.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 253279 442506 566463 743131 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-30 19:03 UTC by V Sridhar
Modified: 2015-11-02 16:46 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Calendar Screenshot (93.55 KB, image/png)
2007-05-31 16:08 UTC, V Sridhar
  Details
proposed eds patch (22.11 KB, patch)
2008-12-04 18:10 UTC, Milan Crha
needs-work Details | Review
proposed evo patch (5.36 KB, patch)
2008-12-04 18:15 UTC, Milan Crha
needs-work Details | Review

Description V Sridhar 2007-05-30 19:03:50 UTC
Hi,

Even if I disable the views - checkboxes, the left pane still continues to show
CalDav-OnthisComputer-Personal
On The Web-Contacts-Birthdays
Weather

Can these be disabled from the view (by having a setup with account details) and thus user getting more screenspace for say additional month calendars display
Comment 1 Chenthill P 2007-05-31 08:29:03 UTC
Have you unmarked the menu item View->Layout->Show side bar ?
Comment 2 V Sridhar 2007-05-31 16:08:18 UTC
Created attachment 89113 [details]
Calendar Screenshot

Screenshot of Calendar Pane
Comment 3 V Sridhar 2007-05-31 16:09:15 UTC
Hi,

a) I haven't unmarked the "View - Layout - ShowSidebar"
That being the life-blood of navigation in the email view between the various folders.

In the calendar view, again it is useful to have the Sidebar - for calendar month displays etc.


b) Attached image screenshot.
When I am online, the last calendar - exchange connect - is checked.


The point I was raising was :

--> Weather, I have disabled in the plugins - still it comes up here
--> Contacts, On This Computer
These again, take up screen  space.

I only want to work with one calendar - the one that is "shared" on the Exchange server. 

So, this observation was about screen space usage.
If none of the other calendar options get displayed, then I can drag up the month calendars to have more views.


Also, even on right-click-delete of Birthdays, the calendar still comes up as an option in the sidepane.


Rgds
Sridhar
Comment 4 Milan Crha 2008-12-04 18:10:34 UTC
Created attachment 123955 [details] [review]
proposed eds patch

for evolution-data-server;

I think it'll be useful to have also ability to change order of the groups, thus it's a bit longer. Feel free to change wording and so on (in evo's patch as well), I'm really not good in such things.
Comment 5 Milan Crha 2008-12-04 18:15:25 UTC
Created attachment 123956 [details] [review]
proposed evo patch

for evolution;

Corresponding popup menu items in the calendar.
Comment 6 Matthew Barnes 2008-12-04 18:29:22 UTC
Didn't this get fixed already by bug #547952?
We don't show empty groups in the sidebar anymore.
Comment 7 Matthew Barnes 2008-12-04 18:32:37 UTC
Hmm, I guess bug #547952 only satisfied part of the request here.

It would have addressed the CalDAV, On The Web, and Weather parts of the screenshot.
Comment 8 Milan Crha 2008-12-04 19:51:11 UTC
Yes, only a little part, empty groups, not nonempty, but all sources disabled.
Also changing order isn't there yet.
Comment 9 Matthew Barnes 2008-12-04 20:35:15 UTC
The reordering could be done via drag-and-drop directly in the sidebar.

I'll try to review your patches tomorrow and provide better feedback.
Comment 10 Milan Crha 2008-12-05 11:55:45 UTC
(In reply to comment #9)
> The reordering could be done via drag-and-drop directly in the sidebar.

I cannot drag&drop neither groups nor sources in the ESourceSelector, in calendar view for example, actual trunk.
Comment 11 Matthew Barnes 2008-12-05 12:49:55 UTC
Right, it's not implemented.  I was suggesting it as a way to support reordering groups.  Sorry if I wasn't clear.  :)
Comment 12 Chenthill P 2009-01-19 08:31:22 UTC
The patch looks good. It would be good if a user unselects a group in 'Manage Groups' dialog to unselect all the sources and hide the group. I just got confused when I was trying to hide hte 'Contacts' group with the source inside it selected and had no clue why the group was not hidden. 

The empty groups which are already hidden in the side bar can be hidden in Manage Groups dialog also. It would be good to have the menu item under main menu 'View' as well.


The patch works fine. Please commit the patch by today after making the above changes. Please announce the string changes after the commit.

Just a small thing,
+	sort_groups (GTK_TREE_MODEL (tree_store), groups); 
is it required to be called inside rebuild_model as it is only required when a user changes the order of groups from manage groups dialog. (not a big thing, can be dealt with later)
Comment 13 Milan Crha 2009-01-19 14:39:50 UTC
(In reply to comment #12)
> Just a small thing,
> +       sort_groups (GTK_TREE_MODEL (tree_store), groups); 
> is it required to be called inside rebuild_model as it is only required when a
> user changes the order of groups from manage groups dialog. (not a big thing,
> can be dealt with later)

It takes in effect also when you add new calendar to the hidden group. if you do not sort groups, then you see new group, with the new source, as the last one, even the right order is different.
Comment 14 Milan Crha 2009-01-19 15:50:25 UTC
Err, I cannot get running those two things at the moment.
 - Menu items seem to involve many changes on evo side;
 - Auto-disable sources has trouble with a reference counting.

I'm postponing it on later.
Comment 15 Milan Crha 2009-03-31 17:23:32 UTC
*** Bug 566463 has been marked as a duplicate of this bug. ***
Comment 16 Milan Crha 2009-06-17 17:15:37 UTC
Chen, would you mind to use the original versions and improve the UI as soon as the kill-bonobo lands in master? (Or some time very soon)
Comment 17 Milan Crha 2009-07-02 17:47:13 UTC
*** Bug 253279 has been marked as a duplicate of this bug. ***
Comment 18 André Klapper 2012-06-16 17:19:02 UTC
(In reply to comment #14)
> I'm postponing it on later.

mcrha: Willing to pick this up again?
Comment 19 Matthew Barnes 2012-06-16 18:17:58 UTC
With account information now moved to key files, I'd say let the user disable it through the key file (set Enabled=false) and leave it out of Evolution's UI.
Comment 20 Milan Crha 2012-06-18 07:06:25 UTC
If there will be a source list "manager", which will cover ordering, then enable/disable may be simple to have. I'll try to have this done for 3.6.0, but no promises.
Comment 21 Matthew Barnes 2012-06-18 11:09:50 UTC
evolution-source-viewer can be made to cover that.  I don't think it belongs in Evolution.
Comment 22 Milan Crha 2012-06-18 17:11:19 UTC
(In reply to comment #21)
> evolution-source-viewer can be made to cover that.  I don't think it belongs in
> Evolution.

I would like to change order of groups in my source list, as I do not like the one being picked "randomly". Similar how can change order of sources for mailer view. Furthermore, currently the evolution-source-view is part of eds/tests/libedataserverui, which I do not expect being installed for regular users. Otherwise, if it can cover both things in a user friendly way (users might not need to know about internal file formats), then I'm all for an external tool for this kind of management.
Comment 23 Milan Crha 2015-02-12 07:51:18 UTC
*** Bug 743131 has been marked as a duplicate of this bug. ***
Comment 24 Milan Crha 2015-09-22 15:46:58 UTC
I finally managed to return back to this. I added context menu options "Manage groups..." and their counterparts into the View menus of the Contacts, Calendar, Tasks and Memos views, where the groups can be reordered and eventually hid (they cannot be hidden in the Contacts view, elsewhere they can). The settings is used only in the views, not on other places where the list of available sources is shown to the user. Enabling any source inside the group shows the group as before, but still keeps the information about the preference of it being hidden, thus the next time all sources are deselected in that group the group is hidden too (the next rebuild of the view).

Created commit e96bff0 in evo master (3.19.1+)
Comment 25 Milan Crha 2015-11-02 16:46:05 UTC
*** Bug 442506 has been marked as a duplicate of this bug. ***