GNOME Bugzilla – Bug 547952
Don't display source groups
Last modified: 2013-09-14 16:52:50 UTC
The address book and the calendar component have various categories: Address book - On this computer - On LDAP servers - WebDAV - Google Calendar - On this computer - Contacts - On the web - CalDAV - Weather - Google Most users will not have an entry in all of those groups, still empty groups are shown, which looks bad IMHO. Empty groups can not even be used to create new entries inside them so they are essentially useless. It would be nice if those group headers would only be shown if there's actually something inside.
Created attachment 116696 [details] Screenshot
I've been wanting to fix this for _ages_. Do you think this would qualify as a UI change? Freeze is Monday. (One could argue it's a _bug_, not a change.)
I would argue it's a usability bug because it could potentially confuse users :) I think you would be fine to fix this even after monday, would be great to have this fixed before 2.24.0.
Created attachment 116715 [details] [review] Proposed patch Figures. Took all of about ten minutes (mostly to compile and test). Deleting the last source in a group still leaves behind an empty group until restart. Probably something signal-related: not listening for a "row-deleted" tree view signal or something like that. I'm not gonna worry about it for now.
Just testing this against trunk. Seems to work fine and gives a lot of polish for such a small patch. Groups show up if needed without a restart (e.g. you add a new google source when you did not have one before) which is the important case.
Looks fine to me. I dont think it is a UI Change.
Committed to trunk (revision 9362).