After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433371 - Add support for activation failure
Add support for activation failure
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 428290
 
 
Reported: 2007-04-25 17:25 UTC by Jan Arne Petersen
Modified: 2007-04-26 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implementation (13.19 KB, patch)
2007-04-25 17:29 UTC, Jan Arne Petersen 		accepted-commit_now Details | Review

Description Jan Arne Petersen 2007-04-25 17:25:43 UTC 
It should be possible for plugins to fail the activation.
Comment 1 Jan Arne Petersen 2007-04-25 17:29:21 UTC 
Created attachment 86999 [details] [review]
Implementation

- the galago plugin fails if there is an error connecting to the galago daemon
- the lirc plugin fails if it isn't possible to initialize lirc.

additional an unitialized parent_class bug in the galago plugin is fixed in this patch.
Comment 2 Bastien Nocera 2007-04-25 22:14:06 UTC 
Looks great, thanks for the patch!
Comment 3 Jan Arne Petersen 2007-04-26 09:59:44 UTC 
2007-04-26  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* src/plugins/galago/totem-galago.c:
	(totem_galago_plugin_finalize), (impl_activate):
	* src/plugins/lirc/totem-lirc.c: (impl_activate):
	* src/plugins/media-player-keys/totem-media-player-keys.c:
	(impl_activate):
	* src/plugins/ontop/totem-ontop.c: (impl_activate):
	* src/plugins/screensaver/totem-screensaver.c: (impl_activate):
	* src/plugins/totem-plugin.c: (totem_plugin_error_quark),
	(totem_plugin_activate):
	* src/plugins/totem-plugin.h:
	* src/plugins/totem-plugins-engine.c:
	(totem_plugins_engine_activate_plugin_real),
	(totem_plugins_engine_activate_plugin): Add support for plugin
	activation failure. Fix an uninitialized variable. (Closes #433371)