Created attachment 86954 [details] [review]
New plugin

The plugin should probably fail to activate if there's no gromit binary available.

I thought about it, but it doesn't seem to be possible with the current plugin framwork.

Maybe we could use something like

typedef gboolean (*TotemPluginActivationFunc) (TotemPlugin *plugin, TotemObject *totem, GError **error);

instead of

typedef void (*TotemPluginActivationFunc) (TotemPlugin *plugin, TotemObject *totem);

Looks useful. Do you want to take a crack at it?

See bug 433371.

Created attachment 87072 [details] [review]
Updated patch.

Looks good. Please don't forget to update po/POTFILES.in

2007-04-26  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* configure.in:
	* src/Makefile.am:
	* src/plugins/gromit/Makefile.am:
	* src/plugins/gromit/gromit.totem-plugin.in:
	* src/plugins/gromit/totem-gromit.c:
	(totem_gromit_plugin_class_init), (totem_gromit_plugin_init),
	(totem_gromit_plugin_finalize), (totem_gromit_available),
	(totem_gromit_exit), (totem_gromit_timeout_cb),
	(totem_gromit_toggle), (totem_gromit_clear),
	(on_window_key_press_event), (impl_activate), (impl_deactivate):
	* src/totem-gromit.c:
	* src/totem-gromit.h:
	* src/totem.c: (totem_action_exit),
	(totem_action_handle_key_press): Move gromit annotation support into a
	new plugin. (Closes #428290)