GNOME Bugzilla – Bug 419350
Evolution Emoticons / Smileys
Last modified: 2007-08-24 09:19:35 UTC
The bug has been opened on https://launchpad.net/bugs/91149 "Binary package hint: evolution I have the base binary package of evolution installed and the emoticons show up as red X's. Even when you select the option to automatically insert smileys for html mail it still doesn't work. I don't know if this matters but I am not using the default Human theme of Feisty. I am trying out the BluBuntu theme. I am using Feisty and have all recent updates applied. Evolution is version 2.9.92 Thanks."
Created attachment 84770 [details] [review] call gtk_icon_info_free() after using the data
Right. Please commit to stable/trunk.
fix commited to gnome-2-18 and trunk 2007-04-02 Sebastien Bacher <seb128@ubuntu.com> * menubar.c: (smiley_cb): fix emoticons use (Closes: #419350)
I have upgrade from Feisty to Edgy and I am using Evolution 2.10.1 Ubuntu packages installed evolution 2.10.1-0ubuntu2 and gtkhtml 3.14.1-0ubuntu2. The bug seems to be back. If more information is required, please let me know.
*** Bug 456409 has been marked as a duplicate of this bug. ***
reopening, as i still get a red cross on gtkhtml 3.15.6svn.
Do you use the menu item or the automatic drawing which has bug #441582?
Created attachment 93600 [details] Text versus image when using menu item
As you can see from the attachment I posted earlier, there is (in various cases) a difference between the text in the menu item and the actual emoticon displayed. When using automatic drawing, indeed bug #441582 is the case. Don't know if there is a relationship though. If more information is required, please let me know.
Created attachment 93972 [details] [review] This attachment displays the correct icons with html or without html option selection in the insert menu of composer window. This is a patch to justify following things 1. Displays correct icons on typing the plain text emoticons viz. disabling the html emoticons 2. Displays correct icons on inserting the html based emoticons by selecting the same in the insert menu of the composer window. 3. Does a job of mapping correctly plain text emoticons to html based once on changing from without html to with html option. 4. Does a job of mapping correctly html based emoticons to plain text once on disabling the html option in the insert menu of composer window.
The diff is wrong.
Created attachment 93978 [details] [review] This attachment contains the patch in rpoper format, ignore earlier one This patch solves the problem of displaying emoticons correctly in both html and plain text format. All the comments given in earlier version of attachment are supported by this.
Rashmi, the label and the tip dont match. You need to rework that.
Comment on attachment 93978 [details] [review] This attachment contains the patch in rpoper format, ignore earlier one >Index: html-editor/GNOME_GtkHTML_Editor.xml.in >=================================================================== >--- html-editor/GNOME_GtkHTML_Editor.xml.in (revision 8535) >+++ html-editor/GNOME_GtkHTML_Editor.xml.in (working copy) >@@ -26,11 +26,11 @@ > <cmd name="InsertTextFile" _label="Te_xt File..." _tip="Insert text file into document..."/> > <cmd name="InsertHTMLFile" _label="_HTML File..." _tip="Insert HTML file into document..."/> > <cmd name="InsertSmiley1" _label="_Smile" _tip="Insert Smile emoticon into document..."/> >- <cmd name="InsertSmiley2" _label="_Wink" _tip="Insert Wink emoticon into document..."/> >- <cmd name="InsertSmiley3" _label="Su_rprised" _tip="Insert Surprised emoticon into document..."/> >- <cmd name="InsertSmiley4" _label="_Laughing" _tip="Insert Laughing emoticon into document..."/> >+ <cmd name="InsertSmiley2" _label="Su_rprised" _tip="Insert Surprised emoticon into document..."/> >+ <cmd name="InsertSmiley3" _label="_Wink" _tip="Insert Wink emoticon into document..."/> >+ <cmd name="InsertSmiley4" _label="_Frown" _tip="Insert Frown emoticon into document..."/> > <cmd name="InsertSmiley5" _label="Oh _No!" _tip="Insert Oh no! emoticon into document..."/> >- <cmd name="InsertSmiley6" _label="_Frown" _tip="Insert Frown emoticon into document..."/> >+ <cmd name="InsertSmiley6" _label="_Laughing" _tip="Insert Laughing emoticon into document..."/> > <cmd name="InsertSmiley8" _label="_Indifferent" _tip="Insert Indifferent emoticon into document..."/> > <cmd name="InsertSmiley9" _label="_Undecided" _tip="Insert Undecided emoticon into document..."/> > <cmd name="InsertSmiley10" _label="Ton_gue" _tip="Insert Tongue emoticon into document..."/> >Index: html-editor/menubar.c >=================================================================== >--- html-editor/menubar.c (revision 8535) >+++ html-editor/menubar.c (working copy) >@@ -679,20 +679,20 @@ > case 1: /* smile */ > emoticon = ":)"; > break; >- case 2: /* wink */ >+ case 2: /* surprised */ >+ emoticon = "=)"; >+ break; >+ case 3: /* wink */ > emoticon = ";)"; > break; >- case 3: /* surprised */ >- emoticon = "=)"; >+ case 4: /* frown */ >+ emoticon = ":("; > break; >- case 4: /* laughing */ >- emoticon = ":D"; >- break; > case 5: /* oh no! */ > emoticon = ":O"; > break; >- case 6: /* frown */ >- emoticon = ":("; >+ case 6: /* laughing */ >+ emoticon = ":D"; > break; > case 8: /* indifferent */ > emoticon = ":-|"; >Index: html-editor/GNOME_GtkHTML_Editor-emacs.xml.in >=================================================================== >--- html-editor/GNOME_GtkHTML_Editor-emacs.xml.in (revision 8535) >+++ html-editor/GNOME_GtkHTML_Editor-emacs.xml.in (working copy) >@@ -26,11 +26,11 @@ > <cmd name="InsertTextFile" _label="Te_xt File..." _tip="Insert text file into document..."/> > <cmd name="InsertHTMLFile" _label="_HTML File..." _tip="Insert HTML file into document..."/> > <cmd name="InsertSmiley1" _label="_Smile" _tip="Insert Smile emoticon into document..."/> >- <cmd name="InsertSmiley2" _label="_Wink" _tip="Insert Wink emoticon into document..."/> >- <cmd name="InsertSmiley3" _label="Su_rprised" _tip="Insert Surprised emoticon into document..."/> >- <cmd name="InsertSmiley4" _label="_Laughing" _tip="Insert Laughing emoticon into document..."/> >+ <cmd name="InsertSmiley2" _label="Su_rprised" _tip="Insert Surprised emoticon into document..."/> >+ <cmd name="InsertSmiley3" _label="_Wink" _tip="Insert Wink emoticon into document..."/> >+ <cmd name="InsertSmiley4" _label="_Frown" _tip="Insert Frown emoticon into document..."/> > <cmd name="InsertSmiley5" _label="Oh _No!" _tip="Insert Oh no! emoticon into document..."/> >- <cmd name="InsertSmiley6" _label="_Frown" _tip="Insert Frown emoticon into document..."/> >+ <cmd name="InsertSmiley6" _label="_Laughing" _tip="Insert Laughing emoticon into document..."/> > <cmd name="InsertSmiley8" _label="_Indifferent" _tip="Insert Indifferent emoticon into document..."/> > <cmd name="InsertSmiley9" _label="_Undecided" _tip="Insert Undecided emoticon into document..."/> > <cmd name="InsertSmiley10" _label="Ton_gue" _tip="Insert Tongue emoticon into document..."/>
Created attachment 93980 [details] [review] patch to #419350,solves the problem of incorrect/inappropriate emoticons display This patch manifests all the comments quoted in comment #10 and comment #12
Created attachment 93981 [details] [review] patch to #419350,solves the problem of incorrect/inappropriate emoticons display This patch manifests all the comments quoted in comment #10 and comment #12
Ill commit it for beta2 release.
Committed to trunk. Committed revision 8542. to Rashmi: Next time, please fill appropriate ChangeLog too. :)