After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415345 - Should add the default Downloads folder to the filechoosers
Should add the default Downloads folder to the filechoosers
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
: 599416 (view as bug list)
Depends on:
Blocks: 602311
 
 
Reported: 2007-03-06 15:17 UTC by Bastien Nocera
Modified: 2010-01-13 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.79 KB, patch)
2009-03-30 23:40 UTC, Ritesh Khadgaray ( irc:ritz) 		rejected Details | Review
patch (643 bytes, patch)
2009-04-30 21:20 UTC, Ritesh Khadgaray ( irc:ritz) 		rejected Details | Review

Description Bastien Nocera 2007-03-06 15:17:41 UTC 
+++ This bug was initially created as a clone of Bug #415338 +++

As well as the currently selected "Downloads" folder from the prefs.

You can use http://freedesktop.org/wiki/Software_2fxdg_2duser_2ddirs to get the default Downloads folder for the user.
Comment 1 Ritesh Khadgaray ( irc:ritz) 2009-03-30 23:40:30 UTC 
Created attachment 131734 [details] [review]
patch

use g_get_user_special_dir, as provided by glib > 2.14,
Comment 2 Christian Persch 2009-04-12 17:57:18 UTC 
This patch doesn't implement what comment 0 suggests.
Comment 3 Ritesh Khadgaray ( irc:ritz) 2009-04-17 22:19:34 UTC 
g_get_user_special_dir uses XDG[1]. What am I missing ?


[1] http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Utility-Functions.html#g-get-user-special-dir
Comment 4 Christian Persch 2009-04-29 20:08:13 UTC 
I think comment 0 asked for adding the XDG downloads dir as a shortcut in the filechooser that shows when accepting a DCC; not to replace this code in the preferences.
Comment 5 Ritesh Khadgaray ( irc:ritz) 2009-04-30 21:20:09 UTC 
Created attachment 133689 [details] [review]
patch

makes sense. Attached a patch to add "pref.dccdir" to filechooser

added note: 
get_save_dir can be simplified with g_get_user_special_dir, removing the need for translation. Should I file another bug report for this, or otherwise ?
Comment 6 Ritesh Khadgaray ( irc:ritz) 2009-10-23 18:52:28 UTC 
*** Bug 599416 has been marked as a duplicate of this bug. ***
Comment 7 Ritesh Khadgaray ( irc:ritz) 2010-01-13 20:58:29 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

http://git.gnome.org/browse/xchat-gnome/commit/?id=53a06edf9697cdbc504342c0674654e5545b24eb
Comment 8 Ritesh Khadgaray ( irc:ritz) 2010-01-13 20:59:34 UTC 
Review of attachment 133689 [details] [review]:

reworked, and fixed.