GNOME Bugzilla – Bug 404827
Each library should have its own customizable folder
Last modified: 2009-05-30 23:36:15 UTC
I would like to be able to specify a certain path to download the music files to. Perhaps a new tab in preferences for plug-in settings?
I just commented on bug http://bugzilla.gnome.org/show_bug.cgi?id=341140 about this too. Not really a duplicate but I think the problems are releated.
*** Bug 411604 has been marked as a duplicate of this bug. ***
Created attachment 86743 [details] See what happens... So this is what happens, I ususally downlaod a few podcasts and they are added to the library, but after the app is restarted they are gone from the podcast source again. I cannot play my podcasts for month now :(
This is resolved in later releases.
"is resolved" as in "will be resolved"? Because, I'm running banshee trunk...
Ok, double checked. Using v0.13.0 podcasts are added to the library and appear across application instances.
Is this bug for downloading them at all or specifying where they are to be downloaded?
As the initial report says: "to specify a certain path to download the music files to"
Retitling this to be more generic. Patch coming.
*** Bug 535025 has been marked as a duplicate of this bug. ***
Created attachment 132481 [details] [review] Patch (with a couple rough edges still) Warning: do not test this patch without backing up your database first (~/.config/banshee-1/banshee.db). This patch lets you choose a folder for Music Library, Video Library, and Podcasts. A lot of the patch is actually changing the format of the Uri field in the database, making all of them absolute uris instead of the current system where some are relative and some are absolute. This helps by letting us change the Video and Podcast folders for this one-time migration, and also for the user to change any of the folder prefs whenever they want, without messing up/orphaning any items already imported b/c we didn't/don't update the relative URIs. There are a couple // TODO library-location items marked in the patch, but I'd appreciate review on the rest.
Created attachment 132484 [details] [review] Updated Remove some cruft from the old patch, and fix the last important bug the old patch had (that I know about), in the Rescan functionality.
The patch works fine for me, but I don't have any videos or podcasts in my library.
I think I ran into a problem with the podcast migration. Before testing, I had one downloaded podcast file : sqlite> select trackid, uri, uritype from coretracks where primarysourceid=2; 2032|Down and Out in the Magic Kingdom/PB-MagicKingdom-07.mp3|1 sqlite> select * from PodcastEnclosures; 1|1|/home/lorentz/Music/Library/Podcasts/Down and Out in the Magic Kingdom/PB-MagicKingdom-07.mp3|http://www.podiobooks.com/chapter/409419/7/70048/PB-MagicKingdom-07.mp3|DownandOutintheMagicKingdom, Cory Doctorow, Science Fiction, podiobook, audio book|2700000|35653960|audio/mpeg||3 After applying the patch and running banshee, this file isn't found anymore. On start-up, I had this message : Moved Podcasts from /home/lorentz/Music/Library/Podcasts to /home/lorentz/Podcasts The file has indeed been moved. Database content is as follows : sqlite> select trackid, uri, uritype from coretracks where primarysourceid=2; 2032|file:///home/lorentz/Music/Library/Podcasts/Down and Out in the Magic Kingdom/PB-MagicKingdom-07.mp3|1 sqlite> select * from PodcastEnclosures; 1|1|/home/lorentz/Podcasts/Down and Out in the Magic Kingdom/PB-MagicKingdom-07.mp3|http://www.podiobooks.com/chapter/409419/7/70048/PB-MagicKingdom-07.mp3|DownandOutintheMagicKingdom, Cory Doctorow, Science Fiction, podiobook, audio book|2700000|35653960|audio/mpeg||3 So it seems the file location is properly updated in PodcastEnclosures, but not in CoreTracks.
Created attachment 132660 [details] [review] Updated Thanks Bertrand, this should fix that. You'll need to restore your backed up db and also mv your Podcasts directory back to where it was (eg for me, mv ~/Podcasts ~/Desktop/Music/Podcasts does the trick)
Fix confirmed, excellent ! I was kind of worried at some point : I did a rescan with the patch, and I think it was adding duplicate tracks in my list view. But after the rescan ended, everything seems fine. I did a second rescan and didn't see any ghost duplicates. Maybe I was not seeing straight...
(In reply to comment #16) > I was kind of worried at some point : > I did a rescan with the patch, and I think it was adding duplicate tracks in my > list view. But after the rescan ended, everything seems fine. > I did a second rescan and didn't see any ghost duplicates. Maybe I was not > seeing straight... Me too, I saw duplicate songs in the music library during the re-scan, but they disappeared after re-scanning finished.
Fixed in git master
*** Bug 583684 has been marked as a duplicate of this bug. ***
*** Bug 543350 has been marked as a duplicate of this bug. ***