GNOME Bugzilla – Bug 397254
properties/ev-properties-main.c refers to non-existant license GPL version 2.1
Last modified: 2007-05-04 10:10:14 UTC
+++ This bug was initially created as a clone of Bug #396930 +++ I noticed that the file src/totem-properties-main.c [http://svn.gnome.org/viewcvs/totem/trunk/src/totem-properties-main.c?rev=3835&view=markup] refers to the GPL, version 2.1. The problem with that is that the Gnu project never released such a version, there is a GPL 2 and a LGPL 2.1, but no GPL 2.1. I guess this is a typo... Also this file seems to be derived from http://svn.gnome.org/viewcvs/gnome-control-center/trunk/vfs-methods/themus/themus-properties-main.c?rev=5388&view=markup (as a diff -uw clearly shows), but seems to have inexplicably gained the totem-gstreamer licence expection on the way...
Created attachment 86344 [details] [review] Change GPL 2.1 to GPL 2 Here's a patch to change the four files I found with this mistake to the GPLv2.
(In reply to comment #0) > +++ This bug was initially created as a clone of Bug #396930 +++ <snip> > Also this file seems to be derived from > http://svn.gnome.org/viewcvs/gnome-control-center/trunk/vfs-methods/themus/themus-properties-main.c?rev=5388&view=markup > (as a diff -uw clearly shows), but seems to have inexplicably gained the > totem-gstreamer licence expection on the way... Yes, Christian chased the authors, and got authorisation from all the copyright holders... except "Eazel". This probably means that I need to see which parts of the file are from Eazel themselves, and are non-trivial/important (ie. is there any other way to do it...). Philip, I committed your patch (seems like I was a bit too trigger happy on the s/details/priv/ when I did that). 2007-05-03 Bastien Nocera <hadess@hadess.net> * src/test-properties-page.c: * src/totem-properties-main.c: * src/totem-properties-view.c: * src/totem-properties-view.h: Fix inexistant version of the GPL being listed as the license (Helps: #397254), Patch from Philip Withnall <bugzilla@tecnocode.co.uk>
This part of the code breaks the GPL :/ We need to fix bug 335533, so that we can keep the properties page going. 2007-05-04 Bastien Nocera <hadess@hadess.net> * COPYING: another excemption/exemption/exception usage * src/totem-properties-main.c: Remove exception from totem-properties-main.c, as it is based on GPL code and will link to a GPL application anyway (Closes: #397254)