After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335533 - Add new d-bus backend
Add new d-bus backend
Status: RESOLVED WONTFIX
Product: totem
Classification: Core
Component: Properties page
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 165396 324821 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-22 15:43 UTC by Bastien Nocera
Modified: 2011-04-03 23:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
totem-dbus-backend-scratch.patch (29.26 KB, patch)
2006-11-01 18:58 UTC, Bastien Nocera
needs-work Details | Review

Description Bastien Nocera 2006-03-22 15:43:18 UTC
This would be something similar to:
http://mail.gnome.org/archives/rhythmbox-devel/2006-February/msg00112.html
With some explanations here:
http://cvs.gnome.org/viewcvs/rhythmbox/metadata/rb-metadata-dbus-client.c?view=markup

1. Create a d-bus client backend/ (akin to the GStreamer and xine-lib ones, only usage type allowed would be BVW_USE_TYPE_METADATA)
2. Create a server d-bus service, it would link against either the GStreamer or xine-lib backend, just like the player
3. Make another version of metadata-test that would compile against d-bus, or the real backend
4. Make the stand-alone properties page link against the d-bus backend, instead of the real backend
Comment 1 Bastien Nocera 2006-09-04 13:54:19 UTC
*** Bug 324821 has been marked as a duplicate of this bug. ***
Comment 2 Tim-Philipp Müller 2006-09-10 12:56:31 UTC
*** Bug 165396 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2006-11-01 18:58:15 UTC
Created attachment 75787 [details] [review]
totem-dbus-backend-scratch.patch

Just the starts. Still needs the actual service done.
Comment 4 Tim-Philipp Müller 2007-02-02 13:09:59 UTC
What I don't really understand is why this should be part of totem (same for the video thumbnailer really).

IMHO all these things should be moved into gnome-media where they can be implemented with minimal overhead. Neither of these things needs the entire totem/bacon-video-widget layer as far as I can see, or do they? All it does is add cruft to totem for special-casing these things (in the GStreamer backend at least).
Comment 5 Bastien Nocera 2007-02-02 14:30:28 UTC
(In reply to comment #4)
> What I don't really understand is why this should be part of totem (same for
> the video thumbnailer really).
> 
> IMHO all these things should be moved into gnome-media where they can be
> implemented with minimal overhead. Neither of these things needs the entire
> totem/bacon-video-widget layer as far as I can see, or do they? All it does is
> add cruft to totem for special-casing these things (in the GStreamer backend at
> least).

I still find that having the xine-lib backend supported provides an invaluable alternative, useful for fixing possible bugs in the common code.
Comment 6 Bastien Nocera 2007-05-04 10:15:01 UTC
As mentioned in bug 397254, we need the D-Bus service, otherwise, using the properties page with the GStreamer backend will break the GPL.

The properties page is GPL code (if it was LGPL, it wouldn't change much, as it would downgrade to GPL when linking to nautilus at run-time), and the GStreamer backend would end up GPL only, and the exception clause would be void.

Whether the properties page is in Totem or another module, it would still need a D-Bus shim to avoid the license mismatch, and allow the use of proprietary GStreamer plugins.
Comment 7 Bastien Nocera 2011-04-03 23:51:32 UTC
We'll just use GstDiscoverer.