After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 394281 - Cleanup playlist parser code
Cleanup playlist parser code
Product: totem-pl-parser
Classification: Core
Component: General
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 350268
Reported: 2007-01-08 16:23 UTC by Bastien Nocera
Modified: 2008-06-03 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Bastien Nocera 2007-01-08 16:23:50 UTC
+++ This bug was initially created as a clone of Bug #350268 +++

Not that it's that long (~2000 lines of code), but it's not really readable.
It would be good to move playlist parsing itself from the rest of the code.

We need to review the includes, and clean up some of the functions.
Comment 1 Bastien Nocera 2007-01-08 17:27:31 UTC
2007-01-08  Bastien Nocera  <>

        * src/plparse/totem-pl-parser-lines.c:
        * src/plparse/totem-pl-parser-media.c:
        * src/plparse/totem-pl-parser-media.h:
        * src/plparse/totem-pl-parser-pls.c:
        * src/plparse/totem-pl-parser-qt.c:
        * src/plparse/totem-pl-parser-smil.c:
        * src/plparse/totem-pl-parser-xspf.c: Clean up includes
Comment 2 Bastien Nocera 2007-01-09 11:44:38 UTC
2007-01-09  Bastien Nocera  <>

        * src/plparse/totem-pl-parser-lines.c: (totem_pl_parser_add_ram),
        * src/plparse/totem-pl-parser-misc.c: (totem_pl_parser_add_gvp),
        * src/plparse/totem-pl-parser-pls.c: (totem_pl_parser_add_pls):
        * src/plparse/totem-pl-parser-private.h:
        * src/plparse/totem-pl-parser-qt.c:
        * src/plparse/totem-pl-parser-wm.c:
        * src/plparse/totem-pl-parser.c: (totem_pl_parser_parse_xml_file):
        Remove totem_pl_parser_read_entire_file() and use gnome-vfs directly,
        require a newer version of gnome-vfs that will null-terminate
        strings from gnome_vfs_read_entire_file()
Comment 3 Bastien Nocera 2007-02-13 10:26:32 UTC
The .ini parser looks a bit arse still, but we're good for the rest.
Comment 4 Philip Withnall 2008-06-03 17:39:58 UTC
Mass-move from totem to totem-pl-parser. You can remove all messages by searching for this comment.