After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350268 - Split playlist parser code
Split playlist parser code
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
Old
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 394281
 
 
Reported: 2006-08-07 13:00 UTC by Bastien Nocera
Modified: 2008-06-03 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
totem-pl-parser-split-1.patch (72.72 KB, patch)
2007-01-08 15:04 UTC, Bastien Nocera
needs-work Details | Review

Description Bastien Nocera 2006-08-07 13:00:56 UTC
Not that it's that long (~2000 lines of code), but it's not really readable.
It would be good to move playlist parsing itself from the rest of the code.
Comment 1 Bastien Nocera 2007-01-08 15:04:01 UTC
Created attachment 79750 [details] [review]
totem-pl-parser-split-1.patch

First go at the patch, there are plenty more to check:
- trim header includes where appropriate
- see whether some -private.h functions could be moved to glib
- finish splitting some larger functions
Comment 2 Bastien Nocera 2007-01-08 16:24:23 UTC
2007-01-08  Bastien Nocera  <hadess@hadess.net>

        * src/plparse/*: Commit huge mess to split the parsers from
        the TotemPlParser object code (Closes: #350268)

Filed bug 394281 to track further cleanups.
Comment 3 Philip Withnall 2008-06-03 17:39:55 UTC
Mass-move from totem to totem-pl-parser. You can remove all messages by searching for this comment.