After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 387152 - muine ditch ColorCellRendererPixbuf and CellRendererText
muine ditch ColorCellRendererPixbuf and CellRendererText
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
trunk
Other All
: Normal normal
: ---
Assigned To: Muine Maintainers
Muine Maintainers
Depends on:
Blocks: 364528
 
 
Reported: 2006-12-18 14:08 UTC by Luis Medinas
Modified: 2008-11-10 00:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
move some code to gtk 2.8 (7.89 KB, patch)
2006-12-18 14:11 UTC, Luis Medinas 		none Details | Review
drop-custom-ColoredCellRendererPixbuf.patch (18.94 KB, patch)
2008-11-08 13:41 UTC, Priit Laes (IRC: plaes) 		accepted-commit_now Details | Review

Description Luis Medinas 2006-12-18 14:08:30 UTC 
Please describe the problem:
Now that we should move to gtk 2.8 here's a patch that replaces ColorCellRendererPixbux and CellRendererText and uses the new ones on gtk2.8

This is a good way to switch to gtk2.8.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Luis Medinas 2006-12-18 14:11:32 UTC 
Created attachment 78564 [details] [review]
move some code to gtk 2.8 

Please take a look if you want you can give me a ok and i'll commit.
Comment 2 Peter Johanson 2007-01-21 18:03:38 UTC 
I've commited stuff to remove the CellRendererText hack (and bumped the dep up to gtk# 2.6 in the process). Unfortunately, the move to regular CellRendererPixbuf isn't as clear cut. You're missing the 'colored' part in the switch over. Notice how the color of the little icon in the playlist changes color based on the row being selected or not? We need to keep that behaviour around when we switch. Unfortunately, the gtk+ 2.8 "follow-state" property is behaving differently than our own ColorCellRendererPixbuf, so it's not a simple switch. Will keep this open to track the status of finishing that piece of this.
Comment 3 Luis Medinas 2008-09-28 02:19:07 UTC 
To be honest i don't see any difference between the current ColoredCellRenderPixbuf and the Gtk one.
Comment 4 Priit Laes (IRC: plaes) 2008-11-08 13:41:36 UTC 
Created attachment 122228 [details] [review]
drop-custom-ColoredCellRendererPixbuf.patch

Updated patch, not sure about the Gtk# requirements bump because I couldn't find any 'Since 2.x' tags in the API docs.
Comment 5 Wouter Bolsterlee (uws) 2008-11-09 21:02:15 UTC 
I'd say: go for it. Bump the GTK dep as well, we're living in 2008 and it's about time to modernize Muine.
Comment 6 Luis Medinas 2008-11-09 21:13:06 UTC 
I'll commit this patch i think this is a must go too.
Comment 7 Luis Medinas 2008-11-10 00:46:29 UTC 
2008-11-10  Luis Medinas  <lmedinas@gnome.org>

        * TODO:
        * configure.in:2008-11-10  Luis Medinas  <lmedinas@gnome.org>

        * TODO:
        * configure.in:
        * libmuine/Makefile.am:
        * src/Makefile.am:
        * src/PlaylistWindow.cs:

        Ditch ColorCellRendererPixbuf and CellRendererText.
        Closes bgo #387152.

        * libmuine/Makefile.am:
        * src/Makefile.am:
        * src/PlaylistWindow.cs:

        Ditch ColorCellRendererPixbuf and CellRendererText.
        Closes bgo #387152.