GNOME Bugzilla – Bug 382323
reduce relocations in atk
Last modified: 2021-06-10 11:24:54 UTC
It's unnecessary to make GTypeInfo and GInterfaceInfo structs static.
Created attachment 77661 [details] [review] patch
Could someone please review this patch?
Created attachment 101543 [details] [review] [PATCH] Use G_DEFINE_TYPE[_WITH_CODE] where possible. For the rest of the atk_foo_get_type() functions, remove the relocations, and use g_type_register_static_simple where possible. Use g_static_intern_string for the signal names. Mark the param spec's nick, blurb and string as static. Bug #382323. --- atk/atkaction.c | 27 ++++---- atk/atkcomponent.c | 34 ++++++---- atk/atkdocument.c | 21 ++++--- atk/atkeditabletext.c | 28 ++++---- atk/atkgobjectaccessible.c | 31 +--------- atk/atkhyperlink.c | 58 ++++------------- atk/atkhyperlinkimpl.c | 24 ++++--- atk/atkhypertext.c | 18 +++--- atk/atkimage.c | 26 ++++---- atk/atkmisc.c | 30 ++------- atk/atknoopobject.c | 151 +++++++++----------------------------------- atk/atknoopobjectfactory.c | 39 +++--------- atk/atkobject.c | 126 +++++++++++++++++-------------------- atk/atkobjectfactory.c | 31 ++-------- atk/atkregistry.c | 38 +---------- atk/atkrelation.c | 41 +++--------- atk/atkrelationset.c | 36 +++-------- atk/atkselection.c | 17 +++-- atk/atkstateset.c | 28 ++------- atk/atkstreamablecontent.c | 27 ++++---- atk/atktable.c | 36 ++++++----- atk/atktext.c | 38 ++++++------ atk/atkutil.c | 32 +++------- atk/atkvalue.c | 27 ++++---- configure.in | 11 +--- 25 files changed, 334 insertions(+), 641 deletions(-)
Patch looks fine to me.
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 . PLEASE NOTE: If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla. Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of atk, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a ticket at https://gitlab.gnome.org/GNOME/atk/-/issues/ Thank you for your understanding and your help.