After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 381254 - GtkComboBox needs "activates-default" property
GtkComboBox needs "activates-default" property
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
unspecified
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
: 309287 (view as bug list)
Depends on:
Blocks: 380848
 
 
Reported: 2006-12-01 13:07 UTC by Sven Neumann
Modified: 2018-05-02 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
halfway done (5.14 KB, patch)
2008-02-18 15:06 UTC, Sven Neumann 		needs-work Details | Review

Description Sven Neumann 2006-12-01 13:07:37 UTC 
GtkComboBox reacts to the Enter key, just like a GtkEntry.  This means that if a dialog has a GtkComboBox as its first focus widget, then the dialog's default action cannot any longer be activated by pressing the Enter key.  GtkEntry has an "activates-default" property that allows an application developer to change the behaviour so that the entry calls gtk_window_activate_default() on the window containing the entry in the default handler for the "activate" signal.  Such a property should also exist on a GtkComboBox.

See bug #380848 for an example of this problem.
Comment 1 Sven Neumann 2008-02-18 15:06:51 UTC 
Created attachment 105506 [details] [review]
halfway done

This patch adds the "activates-default" property as well as getters and setters. What's missing is the actual implementation. I guess the best way to implement this would be to add an "activate" signal to the GtkComboBox and register it as the activate signal. Then do the dispatching to the internal GtkToggleButton and the optional dialog activation from there.
Comment 2 Matthias Clasen 2008-07-15 02:16:06 UTC 
Sounds good to me. 
Do you have a more complete patch ?
Comment 3 Daniel Boles 2017-08-25 01:03:41 UTC 
*** Bug 309287 has been marked as a duplicate of this bug. ***
Comment 4 GNOME Infrastructure Team 2018-05-02 14:23:47 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/272.