After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 380848 - winicon save plug-in should activate when pressing Enter
winicon save plug-in should activate when pressing Enter
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on: 381254
Blocks:
 
 
Reported: 2006-11-30 11:28 UTC by Jakub Steiner
Modified: 2018-05-24 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ogg Theora recording of the focus issue (392.40 KB, application/ogg)
2006-12-01 11:23 UTC, Jakub Steiner
Details

Description Jakub Steiner 2006-11-30 11:28:43 UTC
The windows ico export plugin (*.ico) has the first dropdown widget focused when it opens its dialog. The 'save' button should have focus so that simply pressing 'Enter' will export with the default settings.
Comment 1 Sven Neumann 2006-12-01 10:52:43 UTC
All plug-in dialogs focus the first focusable widget. I don't see why the ICO save plug-in should be any different. Do you suggest that we change all plug-ins to move the focus to the confirm button?
Comment 2 Jakub Steiner 2006-12-01 11:18:53 UTC
Hmm? When I do export to PNG I can just enter, enter, enter and I'm done. If it behaved like the ico plugin, I'd toggle "interlacing (adam7)" on and off.
Comment 3 Jakub Steiner 2006-12-01 11:23:15 UTC
Created attachment 77478 [details]
Ogg Theora recording of the focus issue

The PNG export can be survived by pressing Enter to go with the defaults. ICO export cannot.
Comment 4 Sven Neumann 2006-12-01 11:50:36 UTC
Well, we never focus the confirm button. But we set it as the dialog's default response widget. We also do this is in the winicon plug-in dialog. The focus is automatically set to the first focusable widget in the dialog. Now if this widgets happens to react to the Enter button, then the default action is not activated. This is the case with the combo-box in the winicon save dialog. I am afraid there is no way to change this behaviour. Closing as NOTABUG.
Comment 5 Jakub Steiner 2006-12-01 12:23:44 UTC
How does it happen to react to the Enter button? Is this is a gtk bug that it cannot be solved for this particular case? I recall having similar issues with many other dialogs in the past and you guys fixed them.
 
Comment 6 Sven Neumann 2006-12-01 12:57:38 UTC
We fixes this for dialogs that have focus in a GtkEntry. But there's no equivalent to gtk_entry_set_activates_default() for a GtkComboBox. So there's nothing we can do here. Perhaps you should file a bug against GTK+ asking them to add an "activates-default" property to GtkComboBox.
Comment 7 Sven Neumann 2006-12-01 13:08:10 UTC
I filed bug #381254 for this issue.
Comment 8 Sven Neumann 2006-12-01 13:09:56 UTC
Reopening and changing the summary to something that allows me to keep the report open. The old summary was simply wrong, thus NOTABUG.
Comment 9 Michael Natterer 2012-01-08 22:00:08 UTC
Setting to 2.10 as a reminder for myself, there is a GTK+ patch linked
that needs to be finished.
Comment 10 GNOME Infrastructure Team 2018-05-24 12:05:11 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/223.