After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 379914 - use gtkstatusicon when available
use gtkstatusicon when available
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks:
 
 
Reported: 2006-11-27 21:10 UTC by Christian Persch
Modified: 2008-04-20 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initial patch (31.54 KB, patch)
2006-11-27 21:13 UTC, Christian Persch
none Details | Review

Description Christian Persch 2006-11-27 21:10:45 UTC
On gtk+ >= 2.10, NM-applet should use gtkstatusicon.
Comment 1 Christian Persch 2006-11-27 21:13:44 UTC
Created attachment 77245 [details] [review]
initial patch

First patch; lightly tested in both eggtrayicon (< 2.10) and gtkstatusicon (2.10) modes. More testing appreciated.

I think this patch also fixes bug 336933, bug 351824 and maybe bug 358372 (when using gtkstatusicon at least; but I cannot repro this bug anyway).
Comment 2 Dan Williams 2006-12-03 04:27:48 UTC
Applied to HEAD, thanks.
Comment 3 Sam Morris 2008-04-19 13:48:58 UTC
Would someone please consider backporting this to the 0.6 branch? It is a real pain!
Comment 4 Dan Williams 2008-04-20 13:47:28 UTC
Any particular reason why it's a pain?  The eggtrayicon code should still work with all versions of GTK...
Comment 5 Sam Morris 2008-04-20 14:08:56 UTC
Well, currently whenever gnome-panel crashes, nm-applet exits and has to be restarted by hand. This is bug 336933; which was apparently fixed by the port to GtkStatusIcon.