After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 376149 - Make "totem --fullscreen" work better
Make "totem --fullscreen" work better
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 487931 (view as bug list)
Depends on: 449892
Blocks:
 
 
Reported: 2006-11-17 00:00 UTC by Bastien Nocera
Modified: 2008-02-20 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
totem-better-fs.patch (6.54 KB, patch)
2006-11-17 00:04 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2006-11-17 00:00:36 UTC
Patch attached makes the fullscreen appear without the window flashing on the screen.

Problems left:
- without any files to playback, the video widget doesn't seem to have appeared, and mouse events don't work
- looks very grey on startup, should be black
Comment 1 Bastien Nocera 2006-11-17 00:04:05 UTC
Created attachment 76736 [details] [review]
totem-better-fs.patch
Comment 2 Bastien Nocera 2007-06-21 21:55:38 UTC
Problems:
- window is being wrongly told that it's come out of fullscreen on startup(??)
$ rm ~/.gnome2/Totem/state.ini
$ totem --fullscreen
<quit>
$ totem
(and the fact that we can't unfullscreen it)
- fullscreening doesn't show up until gtk_main()
- bits of gray showing up when fullscreening the first time

2007-06-21  Bastien Nocera  <hadess@hadess.net>

        * data/totem.glade:
        * src/totem-menu.c: (show_controls_action_callback):
        * src/totem-options.c: (totem_options_process_late),
        (totem_options_process_early):
        * src/totem-options.h:
        * src/totem-private.h:
        * src/totem.c: (totem_action_save_state), (totem_action_exit),
        (totem_action_load_media), (totem_action_play_pause),
        (totem_action_pause), (window_state_event_cb),
        (totem_action_fullscreen_toggle), (show_controls),
        (video_widget_create), (main): Handle better having --fullscreen
        passed to the master program (Helps: #376149)

        * src/backend/bacon-video-widget-xine.c: (load_video_out_driver),
        (bacon_video_widget_realize), (xine_event),
        (bacon_video_widget_unrealize), (bacon_video_widget_show),
        (bacon_video_widget_hide), (show_vfx_update),
        (bacon_video_widget_open_with_subtitle),
        (bacon_video_widget_set_show_cursor),
        (bacon_video_widget_set_scale_ratio): Remove the video_window
        struct member, it was barely used. Fix the double-buffering on the
        widget being set/unset wrongly
Comment 3 Bastien Nocera 2007-10-18 16:08:08 UTC
*** Bug 487931 has been marked as a duplicate of this bug. ***
Comment 4 Iain Nicol 2007-12-31 03:02:54 UTC
Part of this bug was fixed in Metacity 2.21.2 (work done towards bug #461927).

Unfullscreening works now.
Comment 5 Bastien Nocera 2008-02-20 17:17:44 UTC
Still gray bits on startup...

2008-02-20  Bastien Nocera  <hadess@hadess.net>

        * src/totem-fullscreen.c: (totem_fullscreen_finalize):
        Avoid warning on exit when we're fullscreen and
        exiting
        * src/totem.c: (totem_action_exit), (main): Fix _set_fullscreen
        being called multiple times on startup, fixes not being able 
        to get out of fullscreen on startup, and the next normal run
        showing up as maximised (Closes: #376149)