GNOME Bugzilla – Bug 368759
progress bar too big in statusbar
Last modified: 2007-03-21 15:24:48 UTC
+++ This bug was initially created as a clone of Bug #368757 +++ Would be nice to use a mini progress bar as totem does. screenshot to come thanks
Created attachment 75755 [details] totem buffering progress bar
Created attachment 75756 [details] epiphany progressbar As seen, the top border of the progress bar overlaps the bottom border of the rendering window. Some padding between the progressbar would give a better finition, but as the statusbar's height cannot be increased, reducing the height of the progressbar as totem did would be nice.
Created attachment 75968 [details] [review] a patch that correct the size issue. it remains a small glitch in the UI, there is no border on the top of the gtkprogressbar
Created attachment 75969 [details] a screenshot of the new progressbar
hmmm, I don't know if I like it.
Then why do you comment ? :)
Created attachment 76182 [details] [review] Better patch This patch seems to be better, because it don't harcode the length of the progressbar, and I chose 10 of height like totem does. Ephy maintainers, you would be so Über cool to review it and commit it for next development version, I love you so much :)
ah yeah I knew I forgot something :) For the small glitch, I would consider to open another bug because it is something out of the scope of this bug. What do you think ?
Pascal: because the idea is to share our opinions about this kind of changes. Baptiste: Is the height of the progressbar "fixed" at that height or it's a side effect of being inside the vbox?.
Created attachment 76191 [details] [review] alternative patch
Christian, I won't comment on the code because you're far better in this than, me :); but for the result this is perfect.
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.
thanks for the patch Christian :)
Sorry to disrupt the party, but usability-wise, in what a smaller progressbar is better? The newbies I watched using epiphany even had a hard time noticing the progressbar when it was full height... but now? it's 2-3 times thinner, wtf? I mean it's less visible... uh... yay? I think this whole issue was started because it overlapped the border of the status bar... Ok, reduce it by 2-3 pixels, but do not cut the height in half! While we are at it, <sarcasm>"why not make all the toolbars small-icons-only"?</sarcasm> :) I came from bug #396000
I think Jeff is right and the progress bar height should be the height of the status bar minus a few pixels. Probably in Totem as well. Although the HIG doesn't mention it specifically, the status bar screenshot on http://developer.gnome.org/projects/gup/hig/2.0/controls-status-bars.html seems to match that idea. Baptiste, Christian, Diego, what do you think?
*** Bug 396000 has been marked as a duplicate of this bug. ***
Should be as simple as removing this line from ephy-statusbar.c: gtk_widget_set_size_request (s->priv->progressbar, -1, 10); We should do this if totem will do the same.
For reference, Rhythmbox has a "big" (old Epiphany style) progress indicator in the status bar. If an agreement is found, a bug against Rhythmbox should be filed as well.
Hi Reinout, something like bug 368757 :)
Removing the gtk_widget_set_size_request doesn't work, since it makes the progressbar too tall, increasing the statusbar's height while it's shown.
What about the old good padding property? (I'm just guessing).
I don't see any way to make it bigger, without it changing the statusbar height when it's shown.
Re-resolving as FIXED since the original bug is fixed. For follow-up, see bug 421060.