GNOME Bugzilla – Bug 368757
progress bar too big in statusbar
Last modified: 2008-06-08 14:53:56 UTC
Would be nice to use a mini progress bar as totem does. screenshot to come thanks
Created attachment 75754 [details] totem buffering progress bar
Created attachment 75757 [details] Rb progressbar As seen, the top border of the progress bar overlaps the bottom border of the rendering window. Some padding between the progressbar would give a better finition, but as the statusbar's height cannot be increased, reducing the height of the progressbar as totem did would be nice.
I thought this patch would have worked, but the progressbar height doesn't change. Index: shell/rb-statusbar.c =================================================================== RCS file: /cvs/gnome/rhythmbox/shell/rb-statusbar.c,v retrieving revision 1.51 diff -u -r1.51 rb-statusbar.c --- shell/rb-statusbar.c 15 Aug 2006 09:42:59 -0000 1.51 +++ shell/rb-statusbar.c 1 Nov 2006 10:19:53 -0000 @@ -158,6 +158,7 @@ statusbar->priv->loading_text = g_strdup (_("Loading...")); gtk_progress_bar_set_fraction (GTK_PROGRESS_BAR (statusbar->priv->progress), 1.0); + gtk_widget_set_size_request ((GTK_WIDGET (statusbar->priv->progress)), 150, 10); gtk_widget_hide (statusbar->priv->progress); gtk_box_pack_start (GTK_BOX (statusbar),
Created attachment 76423 [details] [review] a patch that correct the ui This patch works fine.
Created attachment 76424 [details] [review] previous patch was wrong
Looks fine to me, committed to cvs.
*** Bug 377572 has been marked as a duplicate of this bug. ***
Re-opening because fix means that progress bar no longer fits text, so we need a better solution.
This should be reverted due to the regression noted in bug 377572.
I've reverted the patch.
Created attachment 102576 [details] [review] Patch to copy the behaviour of totem I created a patch that copies the behaviour of totem and epiphany. This works with bigger fonts unlike the old patch. It fixes the jumping statusbar-problem caused by the progressbar being bigger than the normal label in the statusbar and causing the statusbar to "jump" everytime you switched the artist or the album. However it has a small problem with the statusbar getting drawn over the resize grip for a very short moment from time to time. Epiphany also has this problem and i think this is at least better than to have the whole statusbar jumping.
That still doesn't fit the text properly. While ripping a CD, all I see in the progress bar is 'nsferring track 6 out of 9 (1'.
Created attachment 102625 [details] [review] Also fix problem text-width This is an updated version of the patch to fix the width of the text, too.
*** Bug 460641 has been marked as a duplicate of this bug. ***
It seems that just setting the size request on the progress bar has more or less the desired effect, and doesn't clip text noticeably.
*** Bug 323396 has been marked as a duplicate of this bug. ***
I've committed a change that just sets the size request on the progress bar. Hopefully this will go away now.