GNOME Bugzilla – Bug 362591
Middle Click Behavior is not Uniform
Last modified: 2007-04-16 07:24:23 UTC
Reporting this bug upstream from the Ubuntu bugtracker Malone: https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/66400 " Binary package hint: epiphany-browser Facts: →middle-clicking on a bookmark opens it on a separate tab. →middle clicking on the location bar's dropdown list opens the selected item on a separate tab. →middle clicking the "back" button opens the previous page on a separate tab. →typing or pasting an address on the location bar and middle-clicking the "go" button... doesn't do anything. Guess this last item should be corrected, don't you. "
I might as well add that middle clicking on a folder or topic of multiple tabs on the toolbar or even in the bookmarks menu does nothing at all instead of opening them in new tabs, as it probably should.
*** Bug 362882 has been marked as a duplicate of this bug. ***
Can anybody give me a help to start?
Check src/ephy-link.c. See bug #334463.
Created attachment 76539 [details] [review] patch to improve middle click in "Go" button. I think the flags EPHY_LINK_NEW_WINDOW and EPHY_LINK_NEW_TAB should be added always when the middle button is used. Am I right?
No, the patch isn't correct. Middle+shift should be new-window, so those flags are needed. Also the patch doesn't seem to have anything to do with the problem from comment 0, namely that the Go button doesn't check the flags?
Where are the functions/vars relative to the "Go" button?
src/ephy-go-action.c
Created attachment 86330 [details] [review] Changes the callback part, magically it worked. I just changed the g_signal_connect to use a callback and not just gtk_action_activate and it magically works... :/
Looks ok to me. EphyLinkAction handles it similarly, but EphyGoAction cannot use its connect-proxy function since it constructs its proxy differently. Please commit to trunk and gnome-2-18; thanks for the patch!
2007-04-16 Diego Escalante Urrelo <diegoe@gnome.org> * src/ephy-go-action.c: Middle clicking the Go button should open the location bar address content in a new tab. Bug #362591. Committed to trunk and 2-18, revision 6996 & 6997.