After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334463 - Ctrl - middle click does not open new tab
Ctrl - middle click does not open new tab
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-03-13 19:33 UTC by Wouter Bolsterlee (uws)
Modified: 2006-12-05 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makes Ephy open links in new tabs if Control + Middle click is pressed. (335 bytes, patch)
2006-11-03 22:37 UTC, Diego Escalante Urrelo (not reading bugmail)
accepted-commit_now Details | Review

Description Wouter Bolsterlee (uws) 2006-03-13 19:33:25 UTC
Doing a ctrl-middle click on a bookmark in the menu or on the toolbar (both bookmark and topic dropdown) does NOT open a new tab for the page. Ctrl-left click and middle-click (without any modifiers) both open a new tab, so I guess the combination of those should too...
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2006-08-16 07:54:50 UTC
Is it ok to consider ctrl+middle click the same as middle click?
I don't think this is a bug.
Comment 2 Wouter Bolsterlee (uws) 2006-08-16 08:15:53 UTC
Imho it should open a new tab as well.
Comment 3 Christian Persch 2006-08-16 12:05:42 UTC
Ctrl+left-click is equivalent to middle-click; I don't think ctrl+middle-click should do anything special. If you're already pressing ctrl, why not just press left instead of middle?
Comment 4 Wouter Bolsterlee (uws) 2006-08-16 12:18:28 UTC
Because I make mouse mistakes al fscking day :)
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2006-11-03 22:37:27 UTC
Created attachment 75971 [details] [review]
Makes Ephy open links in new tabs if Control + Middle click is pressed.

One liner, just adds an OR to check for GDK_CONTROL_MASK.
Comment 6 Christian Persch 2006-12-04 22:01:39 UTC
I guess this is ok, at least until we assign a dedicated function to ctrl+middle which is rather unlikely :)
Comment 7 Wouter Bolsterlee (uws) 2006-12-05 12:46:17 UTC
2006-12-05  Wouter Bolsterlee  <wbolster@cvs.gnome.org>

    * src/ephy-link.c: (ephy_link_flags_from_current_event):

    Ctrl-middle click on a bookmarm should open a new tab.
    Fixes bug #334463, (trivial) patch by Diego Escalante
    Urrelo).