GNOME Bugzilla – Bug 361894
Building libgtk-java on OpenSolaris
Last modified: 2007-01-05 00:59:25 UTC
This is a set of buildsystem patches to allow libgtk-java to be built on OpenSolaris nevada build48 and above [currently this build uses Gnome 2.14, but will be bumped to Gnome 2.16 shortly]. Changes for the following: 1. Running examples: changes to runExample.sh.in making tests work on OpenSolaris 2. Need gnome2-java-uninstalled.pc.in for common routines for Java-GNOME bindings, Not installed. Needed when building meta/uber packages. 3. Configure --with_javadir is meant to be a supported configure option to tell the build where to put generated jar files, but had some hard coded path bugs and was not being picked up in generated .pc file. 4. Generating Javadoc on OpenSolaris - problem with use of "find -mindep". Not supported on this OS, simple generic workaround added. Also added missing classpath to remove build errors. 5. Applied existing Patch 65224 to create src jar from Bug 339854. 6. Need to change where doc base dir is set in the build, as we wanted to put it in a different location on OpenSolaris. Currently defaulting to ${datadir/doc}. Added configure option --with_docbasedir to support this. 7. Need to change where macro base dir is set in the build, as we wanted to put it in a different location on OpenSolaris. Currently defaulting to ${datadir/doc}. Added configure option --with_macrobasedir to support this. Both docbasedir and macrobasedir support requires the glib macro jg_common.m4 Patch 74620 Bug 360207
Created attachment 74621 [details] [review] Patches for building libgtk-java on OpenSolaris
Typo for gnome2-java-uninstalled.pc.in in 1. gtk2-java-uninstalled.pc.in
Why does http://bugzilla.gnome.org/attachment.cgi?id=74621&action=diff#libgtk-java-2.8.5.orig/doc/examples/runExample.sh.in_sec2 reference explicit jar locations + versions? That would seem to be one of those "oops I worked on the generated file, not the .in one" glitches. Ah, the joys of the anti-patterns relating to generated code... AfC
Opps - I screwed up, put it down to general patch fatigue :) I should not have been using the explicit jar locations + versions, I was indeed patching the generated version instead of the .in file.
Created attachment 74835 [details] [review] Patches for building libgtk-java on OpenSolaris Replaced hardcoded jar paths with @CAIROJAR@ @JGJAR@
Good show. Thanks for that, John. [Always much better for submitters to fix their own bugs - their headspace is closer to a particular bit of code than a reviewers probably is. And the extra work encourages the right behaviour in the future! :)] Will apply. AfC